Paths

Table of Contentst

Differential D38142

zoneinfo: On amd64, include 32-bit data.
ClosedPublic
Actions

Authored by des on Jan 21 2023, 2:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 31, 1:03 PM

	Unknown Object (File)
	Mon, Oct 28, 4:51 AM

	Unknown Object (File)
	Oct 12 2024, 9:12 AM

	Unknown Object (File)
	Oct 3 2024, 6:28 PM

	Unknown Object (File)
	Sep 27 2024, 10:23 PM

	Unknown Object (File)
	Sep 27 2024, 2:39 AM

	Unknown Object (File)
	Sep 25 2024, 9:50 AM

	Unknown Object (File)
	Sep 24 2024, 5:09 AM

View All 72 Files

Subscribers

Details

Reviewers

imp
allanjude

Group Reviewers

Commits

rG783c318fd118: zoneinfo: On amd64, include 32-bit data.

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49189
Build 46078: arc lint + arc unit

Event Timeline

des created this revision.Jan 21 2023, 2:40 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 21 2023, 2:40 PM

des requested review of this revision.Jan 21 2023, 2:40 PM

des added a parent revision: D38141: tzcode: Document zic's -D option..

Harbormaster completed remote builds in B49189: Diff 115387.Jan 21 2023, 2:40 PM

A little background: by default, old zic produces zoneinfo files containing both 32-bit and 64-bit data, while new zic produces only 64-bit data. Dynamic i386 binaries should work correctly since they will be using a 32-bit version of new libc, but static i386 binaries will not work.

BTW, I'm also tempted to drop the -p ${POSIXRULES} part, which (with POSIXRULES=America/New_York) effectively means “when in doubt, assume you're in New York”. The hardcoded default has the same effect, there is no value in enshrining it in the Makefile.

imp accepted this revision.Jan 24 2023, 4:27 PM

This revision is now accepted and ready to land.Jan 24 2023, 4:27 PM

imp added inline comments.Jan 24 2023, 4:28 PM

share/zoneinfo/Makefile
82	Don't we also need this for aarch64 and powerpc64? Both of them have 32-bit binary compat stuff.

In D38142#866566, @des wrote:

BTW, I'm also tempted to drop the -p ${POSIXRULES} part, which (with POSIXRULES=America/New_York) effectively means “when in doubt, assume you're in New York”. The hardcoded default has the same effect, there is no value in enshrining it in the Makefile.

I think that might also be fine. IIRC, years ago (like in the 90s or early 2000s) this was needed because we didn't have a default... but it's been a very very long time and I didn't go back and spelunk the repo to see if this memory is right or not.

des added inline comments.Jan 24 2023, 5:51 PM

share/zoneinfo/Makefile
82	Do their 32-bit counterparts have a 32-bit `time_t`?

brooks added a subscriber: brooks.Jan 24 2023, 9:46 PM

brooks added inline comments.

share/zoneinfo/Makefile
82	Only i386.

des marked 2 inline comments as done.Jan 25 2023, 6:20 AM

des added inline comments.

share/zoneinfo/Makefile
82	That's what I thought, so only amd64 needs 32-bit timezone data.

Explain why only amd64. Remove POSIXRULES.

This revision now requires review to proceed.Jan 25 2023, 6:35 AM

Harbormaster completed remote builds in B49219: Diff 115710.Jan 25 2023, 6:35 AM

Reviewed by: allanjude

This revision is now accepted and ready to land.Jan 25 2023, 1:13 PM

imp accepted this revision.Jan 25 2023, 3:48 PM

imp added inline comments.

share/zoneinfo/Makefile
82	ah, it's 32-bit time_t not 32-bit in general... So never mind.

Closed by commit rG783c318fd118: zoneinfo: On amd64, include 32-bit data. (authored by des). · Explain WhyJan 25 2023, 3:56 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG783c318fd118: zoneinfo: On amd64, include 32-bit data..

des mentioned this in rG93cc70bf9ca7: Bring our tzcode up to date..Jan 31 2023, 9:48 AM

Revision Contents
Changeset List

Path

Size

share/

zoneinfo/

7 lines

Diff 115387

share/zoneinfo/Makefile

Loading...