Page MenuHomeFreeBSD
Differential D38075

netlink: allow creating sockets with SOCK_DGRAM.
ClosedPublic
Actions

Authored by melifaro on Jan 16 2023, 2:20 PM.
Tags
None
Referenced Files
F96364069: D38075.id115189.diff
Tue, Sep 24, 5:24 PM
F96240530: D38075.diff
Tue, Sep 24, 4:39 AM
Unknown Object (File)
Tue, Sep 17, 4:12 PM
Unknown Object (File)
Sat, Sep 14, 4:29 AM
Unknown Object (File)
Tue, Sep 10, 8:23 PM
Unknown Object (File)
Sun, Sep 8, 7:47 AM
Unknown Object (File)
Sat, Sep 7, 7:58 PM
Unknown Object (File)
Fri, Sep 6, 5:45 AM
View All 62 Files
Subscribers
glebius
imp
pauamma_gundo.com

Details

Reviewers
glebius
pauamma_gundo.com
Group Reviewers
network
manpages
Commits
rGedf966085e44: netlink: allow creating sockets with SOCK_DGRAM.
rG0079d177ab69: netlink: allow creating sockets with SOCK_DGRAM.
Summary

Some existing applications setup Netlink socket with
SOCK_DGRAM instead of SOCK_RAW. Update the manpage to clarify
that the default way of creating the socket should be with
SOCK_RAW. Update the code to support both SOCK_RAW and SOCK_DGRAM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errortests/sys/netlink/test_nl_core.py:19E501PEP8 E501
Errortests/sys/netlink/test_nl_core.py:32E501PEP8 E501
Unit
No Test Coverage
Build Status
Buildable 49135
Build 46024: arc lint + arc unit

Event Timeline

melifaro created this revision.Jan 16 2023, 2:20 PM
Herald added subscribers: glebius, imp. · View Herald TranscriptJan 16 2023, 2:20 PM
melifaro requested review of this revision.Jan 16 2023, 2:20 PM
Harbormaster completed remote builds in B49134: Diff 115188.Jan 16 2023, 2:20 PM
melifaro added reviewers: glebius, network, manpages.Jan 16 2023, 2:21 PM
melifaro updated this revision to Diff 115189.Jan 16 2023, 3:13 PM

Add tests.

Harbormaster completed remote builds in B49135: Diff 115189.Jan 16 2023, 3:13 PM
pauamma_gundo.com accepted this revision.Jan 19 2023, 1:15 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Manual page change LGTM. Can't attest to consistency with source code.

This revision is now accepted and ready to land.Jan 19 2023, 1:15 PM
This revision was landed with ongoing or failed builds.Jan 21 2023, 3:00 PM
Closed by commit rG0079d177ab69: netlink: allow creating sockets with SOCK_DGRAM. (authored by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG0079d177ab69: netlink: allow creating sockets with SOCK_DGRAM..
melifaro added a commit: rGedf966085e44: netlink: allow creating sockets with SOCK_DGRAM..Jan 23 2023, 10:15 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
4 lines
2 lines
sys/
netlink/
44 lines
tests/
sys/
netlink/
1 line
33 lines

Diff 115189

View Options

share/man/man4/netlink.4

Loading...
View Options

share/man/man4/rtnetlink.4

Loading...
View Options

sys/netlink/netlink_domain.c

Loading...
View Options

tests/sys/netlink/Makefile

Loading...
View Options

tests/sys/netlink/test_nl_core.py

Loading...