kern/clock: remove interrupt reporting from watchdog_fire()
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Dec 24 2022, 7:49 PM.

Details

Reviewers

mhorne
fuz

Commits

rG3aed0ffc1588: kern/clock: remove interrupt reporting from watchdog_fire()

Summary

The interrupt counts may have been valuable in the past, but now DDB can
readily provide them. Since the full list of counters is expected to
disappear from the global space, remove the reporting from
watchdog_fire().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ehem_freebsd_m5p.com created this revision.Dec 24 2022, 7:49 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 24 2022, 7:49 PM

ehem_freebsd_m5p.com requested review of this revision.Dec 24 2022, 7:49 PM

Harbormaster completed remote builds in B48881: Diff 114532.Dec 24 2022, 7:50 PM

@mhorne, you're the one who suggested this at https://reviews.freebsd.org/D36610#858610. Almost seems too small to bother with the review system, but at the same time.

ehem_freebsd_m5p.com mentioned this in D36609: intr: add interrupt FOREACH macro.Dec 24 2022, 8:02 PM

fuz requested changes to this revision.Jan 31 2023, 12:27 AM

fuz added a subscriber: fuz.

fuz added inline comments.

sys/kern/kern_clock.c
830–831	With this change, interrupt information is no longer dumped. Comment should be adapted.

This revision now requires changes to proceed.Jan 31 2023, 12:27 AM

ehem_freebsd_m5p.com edited the summary of this revision. (Show Details)Jan 31 2023, 12:54 AM

True enough, edit the comment too.

Harbormaster completed remote builds in B49346: Diff 116090.Jan 31 2023, 12:55 AM

Looks good on style alone, though I can't say much about functionality. I wonder if intrcnt, intrnames, and friends will still be needed after this change.

This revision is now accepted and ready to land.Jan 31 2023, 10:45 AM

In D37870#869982, @fuz_fuz.su wrote:

Looks good on style alone, though I can't say much about functionality. I wonder if intrcnt, intrnames, and friends will still be needed after this change.

They definitely still are. I aim to get them removed, but I need reviewers/committers.

Thanks, I can get this one committed without any dependencies. I will check out D36610 before the week is over.

Closed by commit rG3aed0ffc1588: kern/clock: remove interrupt reporting from watchdog_fire() (authored by ehem_freebsd_m5p.com, committed by mhorne). · Explain WhyFeb 16 2023, 9:28 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG3aed0ffc1588: kern/clock: remove interrupt reporting from watchdog_fire().