Mechanically convert qlnx(4) to DrvAPI

[zlei]

sys/dev/qlnx/qlnxe/qlnx_os.c

2378

Missing if_sethwtsomaxsegcount(ifp, QLNX_MAX_SEGMENTS - 1); /* hdr */

2993

style(9)

6802–6803

style(9)

[jhibbits]

sys/dev/qlnx/qlnxe/qlnx_os.c

2378

Odd, wonder how that got lost.

2993

These style issues were preexisting, but I'll fix them.

6802–6803

Same as above, preexisting style bugs.

[jhibbits]

Address @zlei's feedback.

[jhibbits]

Any further comments on this?

[zlei]

Looks good to me.

I admit that the diff https://reviews.freebsd.org/D37856?id=117248 frustrated me a lot.

I'd suggest that submit the new changes following a rebased one. Then the flow looks like:

# git fetch freebsd
# git rebase freebsd/main
# git diff -U9999 freebsd/main you-working-branch > xxx.diff
# submit xxx.diff immediately
# commit new changes
# git diff -U9999 freebsd/main you-working-branch > yyy.diff
# submit yyy.diff

So we can compare new changes with the rebased one. It will be much easier to review.

[jhibbits]

In D37856#893389, @zlei wrote:

Looks good to me.

I admit that the diff https://reviews.freebsd.org/D37856?id=117248 frustrated me a lot.

Urgh, I see what you mean. phabricator diff really sucks. I'll do what you suggested in the future (hopefully not too many changes remaining....), so it's easier to compare.