.github: Switch to v3 of actions/checkout.
ClosedPublic
Actions

Authored by jhb on Dec 20 2022, 11:31 PM.

Details

Reviewers

arichardson
emaste

Commits

rGf9345b915b26: .github: Switch to v3 of actions/checkout.
rG54f3a781a2ff: .github: Switch to v3 of actions/checkout.

Summary

GitHub is emitting a warning that v2 is deprecated due to using Node.js

Reported by: GitHub

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 20 2022, 11:31 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 20 2022, 11:31 PM

jhb requested review of this revision.Dec 20 2022, 11:31 PM

Harbormaster completed remote builds in B48783: Diff 114345.Dec 20 2022, 11:31 PM

Tested here: https://github.com/freebsd/freebsd-src/pull/634

Interesting that no other changes are needed

This revision is now accepted and ready to land.Dec 20 2022, 11:36 PM

Commit message looks a bit odd in phab. Sounds like this is just a nodejs update so if it still works LGTM.

In D37769#859024, @emaste wrote:

Interesting that no other changes are needed

I assume that whatever API changes they made between v2 and v3 don't affect our simple use case of checking out the default ref.

In D37769#859028, @arichardson wrote:

Commit message looks a bit odd in phab. Sounds like this is just a nodejs update so if it still works LGTM.

Yeah, I think phab treated the '12.' as a bullet number in formatting somehow. Raw commit message:

Author: John Baldwin <jhb@FreeBSD.org>
Date:   Tue Dec 20 14:54:12 2022 -0800

    .github: Switch to v3 of actions/checkout.
    
    GitHub is emitting a warning that v2 is deprecated due to using Node.js
    12.
    
    Reported by:    GitHub

It's just updating the version of the action we use. Internally v2 uses Node.js 12 and v3 uses Node.js 16. GitHub is deprecating all actions using Node.js 12 at some date in the future (that is what the warning I noticed on a recent run in CheriBSD was about).

Closed by commit rG54f3a781a2ff: .github: Switch to v3 of actions/checkout. (authored by jhb). · Explain WhyDec 21 2022, 12:28 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG54f3a781a2ff: .github: Switch to v3 of actions/checkout..

jhb added a commit: rGf9345b915b26: .github: Switch to v3 of actions/checkout..Feb 22 2023, 9:23 PM