Paths

Table of Contentst

Differential D37685

Fix per-FIB gateway support in rc.d/routing
ClosedPublic
Actions

Authored by andrew.fengler_scaleengine.com on Dec 13 2022, 5:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 4:05 AM

	Unknown Object (File)
	Dec 6 2024, 7:26 AM

	Unknown Object (File)
	Nov 13 2024, 4:03 AM

	Unknown Object (File)
	Oct 25 2024, 9:21 PM

	Unknown Object (File)
	Oct 11 2024, 7:13 AM

	Unknown Object (File)
	Oct 11 2024, 7:11 AM

	Unknown Object (File)
	Oct 8 2024, 7:44 PM

	Unknown Object (File)
	Oct 4 2024, 4:11 AM

View All 50 Files

Subscribers

Details

Reviewers

freebsd_oldach.net
kevans
allanjude

Commits

rGe8deaa3c6b8b: rc.d/routing: Correct setting default gateway for each FIB
rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB

Summary

See: https://reviews.freebsd.org/D22706
There was a mistake in the previous diff. I'm not sure how that ended up that way, but there were a few mistakes in variable names. This patch will complete what was originally written and tested.

It changes 3 variable names to correctly use $_fib instead of $fib, and to prepend any ipv6 static routes, instead of ipv4 static routes to the the ipv6 route list.

Sorry for the mess.

Test Plan

This is what i originally tested in D22706.
It's running in production on several machines running 13.x

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew.fengler_scaleengine.com created this revision.Dec 13 2022, 5:30 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 13 2022, 5:30 PM

andrew.fengler_scaleengine.com requested review of this revision.Dec 13 2022, 5:30 PM

freebsd_oldach.net accepted this revision.Dec 13 2022, 6:13 PM

This revision is now accepted and ready to land.Dec 13 2022, 6:13 PM

allanjude accepted this revision.Jun 26 2023, 6:41 PM

Closed by commit rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB (authored by andrew.fengler_scaleengine.com, committed by allanjude). · Explain WhyJun 26 2023, 6:45 PM

This revision was automatically updated to reflect the committed changes.

allanjude added a commit: rGf81be7a8318b: rc.d/routing: Correct setting default gateway for each FIB.

This fix should be MFCed into stable/13, as it fixes D22706 which has been cherry-picked into stable/13.

I'd suggest to add commit meta message MFC after to have mail reminders.

Can this please be MFCed to stable/13? As mentioned, this fixes a previous incorrect MFC.

In D37685#938781, @freebsd_oldach.net wrote:

Can this please be MFCed to stable/13? As mentioned, this fixes a previous incorrect MFC.

No response from the committer for a long time.

I'll test and MFC if no objections.

MFCed into stable/13 via commit e8deaa3c6b8b .

FreeBSD's Phabricator has some lag and does not reflect the commit.

zlei added a commit: rGe8deaa3c6b8b: rc.d/routing: Correct setting default gateway for each FIB.Aug 31 2023, 3:32 AM

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.d/

6 lines

Diff 123792

libexec/rc/rc.d/routing

Loading...