LinuxKPI: add (skeleton) functions to make things compile
ClosedPublic
Actions

Authored by bz on Dec 3 2022, 11:08 PM.

Details

Reviewers

None

Group Reviewers

Commits

rG649f21d4d7a8: LinuxKPI: add (skeleton) functions to make drivers compile
rG75388b9ca5e5: LinuxKPI: add (skeleton) functions to make drivers compile

Summary

Add more functions to netdevice.h (netif_napi_add_tx() being the only
one implemented) and add platform_device.h and netlink.h in order to
make driver code compile.
The skeleton functions are used only in very limited scope and not at
all in our usage so far but add (invasive) #ifdef if removed.
Add pr_debug() calls to each of them in order to log a TODO (if DEBUG
compiled in) and someone should hit them in the future.

MFC after: 3 days

Test Plan

In the local dev tree I actually use more prominent logging
or even panic on them and have not come across them.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 48606
Build 45492: arc lint + arc unit

Event Timeline

bz created this revision.Dec 3 2022, 11:08 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptDec 3 2022, 11:08 PM

bz requested review of this revision.Dec 3 2022, 11:08 PM

Harbormaster completed remote builds in B48606: Diff 113795.Dec 3 2022, 11:08 PM

• hselasky added a subscriber: • hselasky.Dec 4 2022, 3:02 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/netdevice.h
465	This probably would be READ_ONCE() or the real rcu_dereference() We have network stuff under EPOCH, so READ_ONCE() is appropriate here, event if it is intended for RCU.
sys/compat/linuxkpi/common/include/linux/platform_device.h
41	space after "int"