Page MenuHomeFreeBSD

ipfilter: Fix mismatch in array bounds.
ClosedPublic

Authored by jhb on Nov 29 2022, 7:57 PM.
Tags
None
Referenced Files
F102682230: D37548.id.diff
Fri, Nov 15, 7:32 PM
Unknown Object (File)
Oct 2 2024, 3:32 AM
Unknown Object (File)
Sep 27 2024, 3:55 PM
Unknown Object (File)
Sep 24 2024, 9:54 PM
Unknown Object (File)
Sep 24 2024, 12:41 PM
Unknown Object (File)
Sep 21 2024, 8:30 AM
Unknown Object (File)
Sep 17 2024, 2:55 AM
Unknown Object (File)
Sep 10 2024, 3:54 AM

Details

Summary

Reported by: GCC -Warray-parameter

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp added inline comments.
sys/netpfil/ipfilter/netinet/radix_ipf.c
321

Is '2' the right way to spell [2] here? :)

This revision is now accepted and ready to land.Nov 29 2022, 8:22 PM
sys/netpfil/ipfilter/netinet/radix_ipf.c
33

It matches the spelling here, so yes. :)

sys/netpfil/ipfilter/netinet/radix_ipf.c
363

This function is also full of explicit nodes[0] and nodes[1] references with magic numbers.

sys/netpfil/ipfilter/netinet/radix_ipf.c
363

Sounds good to go then. Thanks for the reason.

cy added inline comments.
sys/netpfil/ipfilter/netinet/radix_ipf.c
363

It is. Input and output.

BTW I am in the process of rewriting this source file to support IPv6.

This revision was automatically updated to reflect the committed changes.