Page MenuHomeFreeBSD

ktls_test: Add debug option to hexdump keys, nonces, and buffers.
ClosedPublic

Authored by jhb on Nov 27 2022, 12:15 AM.
Tags
None
Referenced Files
F102855910: D37509.diff
Mon, Nov 18, 1:26 AM
Unknown Object (File)
Thu, Nov 7, 8:48 PM
Unknown Object (File)
Wed, Nov 6, 3:06 PM
Unknown Object (File)
Wed, Nov 6, 3:06 PM
Unknown Object (File)
Oct 17 2024, 4:15 AM
Unknown Object (File)
Oct 16 2024, 6:56 AM
Unknown Object (File)
Oct 16 2024, 6:15 AM
Unknown Object (File)
Oct 15 2024, 5:37 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48508
Build 45394: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Nov 27 2022, 12:15 AM
markj added inline comments.
tests/sys/kern/ktls_test.c
1230

Why not put this after the if (outbuf_len < sizeof(struct tls_record_layer)) check below?

2010

Is this unrelated?

2021

This too. More below.

This revision is now accepted and ready to land.Nov 30 2022, 4:13 PM
This revision now requires review to proceed.Nov 30 2022, 10:06 PM
tests/sys/kern/ktls_test.c
1230

Because you will potentially get it multiple times. If a read returns part of a record we might get to the the read() call for payload data down at line 1242 but not get the full record (so outbuf_len < record_len still). Then on the next kevent we would try to read more of the data, but on that next event we would get down to line 1235 again and print it out a second time.

2010

Oh, yes. I used the medium tests locally when testing NIC TLS offload at Chelsio internally and we needed a case that was bigger than one MSS, but a smaller size was less overwhelming for debugging data. I'll drop all the medium tests from this.

jhb marked 2 inline comments as done.Nov 30 2022, 10:09 PM
This revision is now accepted and ready to land.Dec 5 2022, 2:42 PM