Page MenuHomeFreeBSD
Differential D37420

ossl: add supprot for ARMv7
AbandonedPublic
Actions

Authored by markj on Nov 17 2022, 2:49 PM.
Tags
None
Referenced Files
F115794558: D37420.diff
Mon, Apr 28, 6:30 PM
Unknown Object (File)
Fri, Apr 25, 3:53 PM
Unknown Object (File)
Tue, Apr 8, 6:17 PM
Unknown Object (File)
Fri, Apr 4, 2:57 AM
Unknown Object (File)
Mar 29 2025, 4:28 AM
Unknown Object (File)
Mar 24 2025, 6:10 AM
Unknown Object (File)
Mar 23 2025, 8:22 PM
Unknown Object (File)
Feb 28 2025, 10:43 AM
View All Files
Subscribers
andrew

Details

Reviewers
wma
mw
jhb
kd
andrew
Summary

This add support for all ciphers that ossl supports on armv7 architecture.
AES is supported only if it can be accelerated with NEON instructions.
AES-CBC handling required some special treatment.
The assembly logic supports only decryption and has some additional requires some additional scratch space.
To work around the block chaining for encryption is done in C.

Tested with cryptotest.py framework.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mkoz_semihalf.com created this revision.Nov 17 2022, 2:49 PM
Herald added a subscriber: andrew. · View Herald TranscriptNov 17 2022, 2:49 PM
mkoz_semihalf.com requested review of this revision.Nov 17 2022, 2:49 PM
kd mentioned this in D37419: arm: Add support for using VFP in kernel.Nov 21 2022, 9:25 AM
mkoz_semihalf.com updated this revision to Diff 113438.Nov 23 2022, 11:43 AM
mkoz_semihalf.com edited the summary of this revision. (Show Details)

remove bsaes-armv7.S changes

mkoz_semihalf.com mentioned this in D37441: param: increase KSTACK for hash context.Nov 30 2022, 1:38 PM
mkoz_semihalf.com updated this revision to Diff 113772.Dec 2 2022, 1:17 PM

Move sys/arm/conf/ARMADA38X from https://reviews.freebsd.org/D37419

mkoz_semihalf.com updated this revision to Diff 113775.Dec 2 2022, 2:39 PM

Add ossl device to GENERIC config

kd commandeered this revision.Dec 13 2022, 11:20 AM
kd edited reviewers, added: mkoz_semihalf.com; removed: kd.
kd updated this revision to Diff 114095.Dec 13 2022, 11:24 AM
kd edited the summary of this revision. (Show Details)
kd added a reviewer: jhb.Dec 13 2022, 11:26 AM
kd mentioned this in D39091: OpenSSL: aes/asm/bsaes-armv7.pl: Replace adrl with add.Mar 15 2023, 11:09 AM
kd updated this revision to Diff 118900.Mar 16 2023, 9:11 AM
kd edited the summary of this revision. (Show Details)
kd removed a reviewer: mkoz_semihalf.com.

The patch has been rewritten from scratch.
In order to build it D39091 has to be applied first.
Then the ossl armv7 assembly logic has to be regenerated - crypto/openssl/crypto/aes/asm/bsaes-armv7.pl > sys/crypto/openssl/arm/bsaes-armv7.S

markj mentioned this in D41304: ossl: Add support for armv7.Aug 3 2023, 6:37 PM
markj mentioned this in rG44f8e1e8530e: ossl: Add support for armv7.Nov 30 2023, 5:52 PM
markj mentioned this in rG15e12749ef1d: ossl: Add support for armv7.Mar 29 2024, 6:14 PM
markj commandeered this revision.Jan 24 2025, 7:15 PM
markj added a reviewer: kd.
Herald added a reviewer: andrew. · View Herald TranscriptJan 24 2025, 7:15 PM
markj abandoned this revision.Jan 24 2025, 7:16 PM

This was committed in 44f8e1e8530e1d2e95e84bbbe3d22ac9cb2557fe

Revision Contents
Changeset List

PathSize
sys/
arm/
conf/
2 lines
1 line
conf/
9 lines
crypto/
openssl/
arm/
84 lines
10 lines
3 lines
48 lines
64 lines
modules/
ossl/
10 lines
opencrypto/
16 lines

Diff 113775

View Options

sys/arm/conf/ARMADA38X

Loading...
View Options

sys/arm/conf/GENERIC

Loading...
View Options

sys/conf/files.arm

Loading...
View Options

sys/crypto/openssl/arm/arm_arch.h

Loading...
View Options

sys/crypto/openssl/ossl.h

Loading...
View Options

sys/crypto/openssl/ossl_aes.c

Loading...
View Options

sys/crypto/openssl/ossl_arm.h

Loading...
View Options

sys/crypto/openssl/ossl_arm.c

Loading...
View Options

sys/modules/ossl/Makefile

Loading...
View Options

sys/opencrypto/cbc_mac.c

Loading...