Differential D37373

ktls: Add tests for receiving corrupted or invalid records.
ClosedPublic
Actions

Authored by jhb on Nov 12 2022, 12:03 AM.

Details

Reviewers

markj

Commits

rG65bd3adbed15: ktls: Add tests for receiving corrupted or invalid records.

Summary

These should all trigger errors when reading from the socket.

Tests include truncated records (socket closed early on the other
side), corrupted records (bits flipped in explicit IVs, ciphertext, or
MAC), invalid header fields, and various invalid record lengths.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 12 2022, 12:03 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 12 2022, 12:03 AM

jhb requested review of this revision.Nov 12 2022, 12:03 AM

Harbormaster completed remote builds in B48317: Diff 113033.Nov 12 2022, 12:03 AM

jhb added a parent revision: D37372: ktls_ocf: Reject encrypted TLS records using AEAD that are too small..Nov 12 2022, 12:03 AM

jhb added inline comments.Nov 12 2022, 12:11 AM

tests/sys/kern/ktls_test.c
1510	I think I ended up with this always being true (no callers pass 0).
1630	TOE TLS at least reports EBADMSG for these errors rather than EMSGSIZE.

markj accepted this revision.Nov 15 2022, 2:25 PM

markj added inline comments.

tests/sys/kern/ktls_test.c
696	Extra newline.
1549	Missing close_sockets() calls after each of the tests.

This revision is now accepted and ready to land.Nov 15 2022, 2:25 PM

jhb marked 2 inline comments as done.Nov 15 2022, 7:47 PM

Closed by commit rG65bd3adbed15: ktls: Add tests for receiving corrupted or invalid records. (authored by jhb). · Explain WhyNov 15 2022, 8:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG65bd3adbed15: ktls: Add tests for receiving corrupted or invalid records..

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

ktls_test.c

651 lines

Diff 113157

View Options

tests/sys/kern/ktls_test.c

ktls: Add tests for receiving corrupted or invalid records.ClosedPublicActions