Page MenuHomeFreeBSD

bhyve: nvme controller obey async event setting when reporting critical temperature
ClosedPublic

Authored by wanpengqian_gmail.com on Nov 11 2022, 7:59 AM.
Tags
None
Referenced Files
F102710552: D37355.diff
Sat, Nov 16, 4:50 AM
Unknown Object (File)
Thu, Nov 14, 9:24 AM
Unknown Object (File)
Sun, Nov 10, 3:32 PM
Unknown Object (File)
Thu, Nov 7, 2:43 PM
Unknown Object (File)
Sat, Nov 2, 8:44 AM
Unknown Object (File)
Wed, Oct 30, 9:11 PM
Unknown Object (File)
Sat, Oct 26, 8:02 PM
Unknown Object (File)
Sep 30 2024, 4:54 AM

Details

Summary

async event report is controlled by async event configuration feature setting.
when reporting a critical temperature warning, check the async event configuration.

Test Plan

trigger a critical temperature event whether the on/off setting is effective.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink added inline comments.
usr.sbin/bhyve/pci_nvme.c
1761

address feedback

usr.sbin/bhyve/pci_nvme.c
1761

this init value will be overridden by the following statement. I think giving an init value to false is reasonable at first.

This revision is now accepted and ready to land.Nov 14 2022, 10:48 AM