ktls: Don't leak ktls session objects for certain errors.
ClosedPublic
Actions

Authored by jhb on Nov 11 2022, 1:58 AM.

Details

Reviewers

markj
gallatin

Commits

rG4f1a2168f685: ktls: Don't leak ktls session objects for certain errors.
rGd01db2b83705: ktls: Don't leak ktls session objects for certain errors.

Summary

ktls_cleanup() does not free ktls session objects, it merely
cleans (and frees) members of the object.

Change callers to use ktls_free() or ktls_destroy() instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48279
Build 45165: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 11 2022, 1:58 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2022, 1:58 AM

jhb requested review of this revision.Nov 11 2022, 1:58 AM

Harbormaster completed remote builds in B48279: Diff 112901.Nov 11 2022, 1:58 AM

jhb added a child revision: D37353: ktls: Inline ktls_cleanup() into ktls_destroy()..Nov 11 2022, 1:58 AM

jhb added inline comments.Nov 11 2022, 2:00 AM

sys/kern/uipc_ktls.c
747	Possibly this could use `ktls_free()` instead as the refcount should always be 1 at this point.

markj accepted this revision.Nov 11 2022, 5:02 PM

markj added inline comments.

sys/kern/uipc_ktls.c
747	I think I slightly prefer that.

This revision is now accepted and ready to land.Nov 11 2022, 5:02 PM

gallatin accepted this revision.Nov 11 2022, 9:23 PM

Closed by commit rGd01db2b83705: ktls: Don't leak ktls session objects for certain errors. (authored by jhb). · Explain WhyNov 12 2022, 12:02 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd01db2b83705: ktls: Don't leak ktls session objects for certain errors..

jhb added a commit: rG4f1a2168f685: ktls: Don't leak ktls session objects for certain errors..Jan 24 2023, 5:43 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_ktls.c

8 lines

Diff 112901

View Options

ktls: Don't leak ktls session objects for certain errors.ClosedPublicActions