A future commit will remove direct access to vCPU structures from
struct vmx, so add a dedicated boolean for this rather than checking
the capabilities for vCPU 0.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
After splitting this out and looking at it again, I think it probably makes sense for it to just be a global bool rather than buried in struct vmx, but I wanted to upload the initial version for comparison.
sys/amd64/vmm/intel/vmx.c | ||
---|---|---|
213 | Did you mean to add a sysctl for this? It seems a bit odd to stick it in the middle of the sysctl definitions otherwise. |
sys/amd64/vmm/intel/vmx.c | ||
---|---|---|
213 | I did not plan for a sysctl for it, no. I'm not sure where else to put this declaration. I had kind of put it in this block here in between sysctl blocks since it is related to cap_rdpid and cap_rdtscp. I can look to see if I can find a less confusing place for it. |