ping_test: Move the requirements to the header

[jlduran]

Summary

No functional change intended.

[jlduran]

Use the right diff.

[markj]

I'm not sure this works? It's not very clear to me what can and what cannot be in the header, but it's usually just used to define test metadata.

If I try adding an unconditional atf_skip to one of the test headers, I get:

markj@nuc> kyua list ping_test
ping_test:__test_cases_list__
markj@nuc> kyua test ping_test
ping_test:__test_cases_list__  ->  broken: Invalid test case definition; must be preceeded by the identifier  [0.001s]

Results file id is usr_tests_sbin_ping.20221103-125835-090128
Results saved to /home/markj/.kyua/store/results.usr_tests_sbin_ping.20221103-125835-090128.db

0/1 passed (1 failed)

[jlduran]

In D37249#845933, @markj wrote:

I'm not sure this works? It's not very clear to me what can and what cannot be in the header, but it's usually just used to define test metadata.

If I try adding an unconditional atf_skip to one of the test headers, I get:

markj@nuc> kyua list ping_test
ping_test:__test_cases_list__
markj@nuc> kyua test ping_test
ping_test:__test_cases_list__  ->  broken: Invalid test case definition; must be preceeded by the identifier  [0.001s]

Results file id is usr_tests_sbin_ping.20221103-125835-090128
Results saved to /home/markj/.kyua/store/results.usr_tests_sbin_ping.20221103-125835-090128.db

0/1 passed (1 failed)

Yes, you are right. I got confused with atf_set require.user root.

I'll abandon this revision, and update the next one. Thank you!