Page MenuHomeFreeBSD
Differential D37223

LinuxKPI: implement cpumask_of()
ClosedPublic
Actions

Authored by bz on Oct 31 2022, 2:39 PM.
Tags
None
Referenced Files
F96564721: D37223.id.diff
Wed, Sep 25, 12:36 PM
Unknown Object (File)
Thu, Sep 19, 6:57 PM
Unknown Object (File)
Thu, Sep 19, 6:18 AM
Unknown Object (File)
Fri, Sep 13, 6:37 PM
Unknown Object (File)
Sun, Sep 8, 11:49 AM
Unknown Object (File)
Sun, Sep 8, 12:20 AM
Unknown Object (File)
Fri, Sep 6, 7:22 PM
Unknown Object (File)
Thu, Sep 5, 7:14 PM
View All 34 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rG51a1eac57dc0: LinuxKPI: implement cpumask_of()
rGe2361e04b02a: LinuxKPI: implement cpumask_of()
Summary

Add a static set of cpumasks for all (possible) cpus with only the one
indexed cpu enabled in each set.
This is needed for cpumask_of(_cpuid) which returns a cpumask (cpuset)
with only cpu _cpuid enabled and is used by one wireless driver at least.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48104
Build 44991: arc lint + arc unit

Event Timeline

bz created this revision.Oct 31 2022, 2:39 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptOct 31 2022, 2:39 PM
bz requested review of this revision.Oct 31 2022, 2:39 PM
Harbormaster completed remote builds in B48104: Diff 112438.Oct 31 2022, 2:39 PM
emaste accepted this revision.Oct 31 2022, 4:14 PM

IMO this ought to have a brief comment somewhere explaining the pregenerated masks.

This revision is now accepted and ready to land.Oct 31 2022, 4:14 PM
bz updated this revision to Diff 112728.Nov 7 2022, 1:13 PM

Add a comment for when generating these 1-CPU masks.

This revision now requires review to proceed.Nov 7 2022, 1:13 PM
Harbormaster completed remote builds in B48207: Diff 112728.Nov 7 2022, 1:14 PM
emaste accepted this revision.Nov 7 2022, 3:34 PM
This revision is now accepted and ready to land.Nov 7 2022, 3:34 PM
Closed by commit rGe2361e04b02a: LinuxKPI: implement cpumask_of() (authored by bz). · Explain WhyNov 8 2022, 6:15 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGe2361e04b02a: LinuxKPI: implement cpumask_of().
bz added a commit: rG51a1eac57dc0: LinuxKPI: implement cpumask_of().Nov 28 2022, 5:30 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines
src/
13 lines

Diff 112438

View Options

sys/compat/linuxkpi/common/include/linux/cpu.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...