Page MenuHomeFreeBSD

LinuxKPI: tasklet add (*callback) support
ClosedPublic

Authored by bz on Oct 30 2022, 5:32 PM.
Tags
None
Referenced Files
F96616664: D37216.diff
Wed, Sep 25, 6:19 PM
Unknown Object (File)
Sun, Sep 22, 8:47 AM
Unknown Object (File)
Sat, Sep 21, 6:43 AM
Unknown Object (File)
Wed, Sep 18, 11:15 PM
Unknown Object (File)
Wed, Sep 18, 3:13 AM
Unknown Object (File)
Tue, Sep 17, 9:17 AM
Unknown Object (File)
Sat, Sep 14, 9:22 PM
Unknown Object (File)
Thu, Sep 5, 3:22 PM
Subscribers

Details

Summary

In addition to (*func) tasklet also seems to have a (*callback) with
a different argument. Add support for this and add tasklet_setup()
as well for support in more drivers.

The from_tasklet() definition is duplicated in the tree; hide it there
under #ifndef to avoid a re-definition. People should generally add
LinuxKPI bits to linuxkpi rather than private files if they also rely
on other LinuxKPI bits.

X-MFC: DO NOT MFC, space allocated by drivers not us.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Oct 30 2022, 5:32 PM

It's been months since I had done this change and I wonder if we could do it without the bool and just check if func is != NULL then use func and otherwise use callback; that would also make it MFCable I think. Someone might have to take a peek at Linux and check if there is the invariant of only func or callback that can be set at one time and whether one has to be set?

if there is the invariant of only func or callback that can be set at one time

This does not appear to be the case.

if there is the invariant of only func or callback that can be set at one time

This does not appear to be the case.

Thanks Ed! So we need the bool and we cannot MFC (correct me if I misunderstand).

Anyone up for the review?

This revision is now accepted and ready to land.Nov 7 2022, 3:33 PM
This revision was automatically updated to reflect the committed changes.