Page MenuHomeFreeBSD
Differential D37214

LinuxKPI: ethtool.h add more definitions
ClosedPublic
Actions

Authored by bz on Oct 30 2022, 5:29 PM.
Tags
None
Referenced Files
F102741887: D37214.id112412.diff
Sat, Nov 16, 2:26 PM
F102708070: D37214.id112412.diff
Sat, Nov 16, 4:05 AM
Unknown Object (File)
Mon, Oct 28, 8:49 AM
Unknown Object (File)
Sun, Oct 20, 2:33 AM
Unknown Object (File)
Sat, Oct 19, 6:14 PM
Unknown Object (File)
Fri, Oct 18, 6:11 AM
Unknown Object (File)
Oct 4 2024, 11:28 PM
Unknown Object (File)
Oct 1 2024, 1:29 PM
View All 57 Files
Subscribers
emaste
imp

Details

Reviewers
None
Group Reviewers
linuxkpi
Commits
rG2078d0ea1e9f: LinuxKPI: ethtool.h add more definitions
rG1b91eba37b29: LinuxKPI: ethtool.h add more definitions
Summary

While we do not currently use this add the definitions to avoid other
longer-term maintenance problems with drivers.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48429
Build 45315: arc lint + arc unit

Event Timeline

bz created this revision.Oct 30 2022, 5:29 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptOct 30 2022, 5:29 PM
bz requested review of this revision.Oct 30 2022, 5:29 PM
Harbormaster completed remote builds in B48095: Diff 112412.Oct 30 2022, 5:29 PM
bz added a comment.Nov 7 2022, 1:15 PM

Anyone?

bz added a comment.Nov 15 2022, 11:03 PM

If no one reviews I'll commit this the next days.

emaste added inline comments.Nov 16 2022, 5:18 PM
sys/compat/linuxkpi/common/include/linux/ethtool.h
48

these are char[] arrays in Linux so I worry this may introduce some misbehaviour in the future (even if they're not being used in a way that would cause that, today)

bz marked an inline comment as done.Nov 18 2022, 9:03 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/ethtool.h
48

Based on a simple user space program, they all seem to be of size [32]; I'll adjust the file and post an update in a minute

bz updated this revision to Diff 113334.Nov 18 2022, 9:05 PM
bz marked an inline comment as done.

Make struct members fixed length char[] based on imput from @emaste and
a simple user space program using the original header file and LinuxKPI.

Also migrate ETH_GSTRING_LEN into here from if_ether.h.

Harbormaster completed remote builds in B48429: Diff 113334.Nov 18 2022, 9:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 28 2022, 5:30 PM
Closed by commit rG1b91eba37b29: LinuxKPI: ethtool.h add more definitions (authored by bz). · Explain Why
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG1b91eba37b29: LinuxKPI: ethtool.h add more definitions.
bz added a commit: rG2078d0ea1e9f: LinuxKPI: ethtool.h add more definitions.Jan 18 2023, 4:25 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
20 lines
2 lines

Diff 113334

View Options

sys/compat/linuxkpi/common/include/linux/ethtool.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/if_ether.h

Loading...