Page MenuHomeFreeBSD
Differential D37205

wg.4: Add some enhancements
ClosedPublic
Actions

Authored by gbe on Oct 29 2022, 1:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:28 PM
Unknown Object (File)
Thu, Nov 7, 3:43 PM
Unknown Object (File)
Thu, Nov 7, 9:07 AM
Unknown Object (File)
Thu, Nov 7, 9:06 AM
Unknown Object (File)
Thu, Nov 7, 9:06 AM
Unknown Object (File)
Thu, Nov 7, 9:06 AM
Unknown Object (File)
Tue, Nov 5, 2:20 PM
Unknown Object (File)
Sun, Nov 3, 10:44 PM
View All 48 Files
Subscribers
imp
mhorne

Details

Reviewers
pauamma_gundo.com
mhorne
Group Reviewers
manpages
Commits
rG78d36c860239: wg.4: Add some enhancements
rG19c03f4ab0d6: wg.4: Add some enhancements
Summary
  • Add a SPDX-License-Identifier
  • Use better grammar in some places
  • Reword 'IPs' to 'IP addresses'
  • Use '.An -nosplit' in the AUTHORS section
  • Add a missing word in the AUTHORS section

MFC after: 1 week

Test Plan

mandoc output review and 'mandoc -Tlint checks'

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48094
Build 44981: arc lint + arc unit

Event Timeline

gbe created this revision.Oct 29 2022, 1:13 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 29 2022, 1:13 PM
gbe requested review of this revision.Oct 29 2022, 1:13 PM
Harbormaster completed remote builds in B48087: Diff 112373.Oct 29 2022, 1:13 PM
mhorne added a subscriber: mhorne.Oct 29 2022, 6:12 PM
mhorne added inline comments.
share/man/man4/wg.4
33

"pseudo-device" is a little strange for the description, IMO. I would suggest: "WireGuard protocol", or "WireGuard protocol driver" instead.

187–188

.Xr ipsec 4 , and .Xr ovpn 4 , would both make sense here too.

pauamma_gundo.com added a comment.Oct 29 2022, 9:47 PM

Other maybe than mhorne's comments, LGTM.

gbe updated this revision to Diff 112402.Oct 30 2022, 8:59 AM
  • Address comments
Harbormaster completed remote builds in B48094: Diff 112402.Oct 30 2022, 8:59 AM
gbe marked 2 inline comments as done.Oct 30 2022, 9:01 AM

@mhorne Comments are addressed. pseudo-device is more an OpenBSD term, where the man page derives from.

gbe accepted this revision as: manpages.Oct 30 2022, 9:01 AM
mhorne accepted this revision.Oct 30 2022, 1:00 PM
In D37205#844871, @gbe wrote:

@mhorne Comments are addressed. pseudo-device is more an OpenBSD term, where the man page derives from.

Ah makes sense! Thanks.

This revision is now accepted and ready to land.Oct 30 2022, 1:00 PM
Closed by commit rG19c03f4ab0d6: wg.4: Add some enhancements (authored by gbe). · Explain WhyOct 30 2022, 1:00 PM
This revision was automatically updated to reflect the committed changes.
gbe added a commit: rG19c03f4ab0d6: wg.4: Add some enhancements.
gbe added a commit: rG78d36c860239: wg.4: Add some enhancements.Nov 11 2022, 10:56 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
25 lines

Diff 112402

View Options

share/man/man4/wg.4

Loading...