Differential D37146

vmm: Simplify saving of absolute TSC values in snapshots.
ClosedPublic
Actions

Authored by jhb on Oct 27 2022, 3:02 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 1:53 PM

	Unknown Object (File)
	Thu, Nov 7, 7:35 AM

	Unknown Object (File)
	Wed, Nov 6, 4:33 PM

	Unknown Object (File)
	Tue, Nov 5, 8:39 AM

	Unknown Object (File)
	Sat, Nov 2, 5:37 PM

	Unknown Object (File)
	Tue, Oct 29, 11:45 AM

	Unknown Object (File)
	Tue, Oct 22, 4:59 AM

	Unknown Object (File)
	Sat, Oct 19, 8:25 AM

Subscribers

Details

Reviewers

markj
corvink
manu

Group Reviewers

Commits

rGa8ffb1a17ce3: vmm: Simplify saving of absolute TSC values in snapshots.
rGa7db532e3a6f: vmm: Simplify saving of absolute TSC values in snapshots.

Summary

Pass the base TSC value in to vm_snapshot_vcpus and save the computed
absolute time rather than iterating over vCPUs multiple times.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 27 2022, 3:02 PM

Herald added a reviewer: bhyve. · View Herald TranscriptOct 27 2022, 3:02 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Oct 27 2022, 3:02 PM

jhb added a child revision: D37147: vmm: Use vm_get_maxcpus() instead of VM_MAXCPU in various places..

Harbormaster completed remote builds in B48018: Diff 112255.Oct 27 2022, 3:03 PM

rew added a subscriber: rew.Oct 27 2022, 7:09 PM

rew added inline comments.

sys/amd64/vmm/vmm.c
2843	why not push this into vm_snapshot_vcpus()?
2854–2857	I think vm_snapshot_vcpu()'s will print an error out from the SNAPSHOT_VAR_OR_LEAVE macro if it fails - not sure this printf() is adding enough to keep it around.

jhb added inline comments.Oct 28 2022, 12:45 AM

sys/amd64/vmm/vmm.c
2843	Well, the goal of this commit is more about removing the hack that modifies tsc_offset and then unmodifies it, so I had left this alone. I guess it wouldn't hurt to move it though.

markj accepted this revision as: markj.Nov 2 2022, 2:16 PM

This revision is now accepted and ready to land.Nov 2 2022, 2:16 PM

jhb marked 2 inline comments as done.Nov 3 2022, 10:35 PM

Move now into the inner function.

This revision now requires review to proceed.Nov 3 2022, 10:35 PM

Harbormaster completed remote builds in B48132: Diff 112572.Nov 3 2022, 10:35 PM

jhb added a child revision: D37258: vmm svm: Use malloc_aligned() instead of contigmalloc()..Nov 3 2022, 11:18 PM

jhb removed a child revision: D37258: vmm svm: Use malloc_aligned() instead of contigmalloc()..

corvink accepted this revision.Nov 4 2022, 6:00 AM

This revision is now accepted and ready to land.Nov 4 2022, 6:00 AM

corvink added a reviewer: manu.Nov 4 2022, 7:01 AM

markj accepted this revision as: markj.Nov 4 2022, 10:59 PM

Closed by commit rGa7db532e3a6f: vmm: Simplify saving of absolute TSC values in snapshots. (authored by jhb). · Explain WhyNov 18 2022, 6:26 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa7db532e3a6f: vmm: Simplify saving of absolute TSC values in snapshots..

jhb added a commit: rGa8ffb1a17ce3: vmm: Simplify saving of absolute TSC values in snapshots..Jan 26 2023, 10:11 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

35 lines

Diff 113285

sys/amd64/vmm/vmm.c

Loading...