Differential D37117

bhyve: Make sure that the VNC version is initialized
ClosedPublic
Actions

Authored by markj on Oct 25 2022, 3:30 PM.

Details

Reviewers

jhb

Group Reviewers

bhyve

Commits

rG04336c056248: bhyve: Make sure that the VNC version is initialized

Summary

clang warned that "client_ver" can be left uninitialized. This change
causes the new connection to be dropped if a version string is not
presented.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 25 2022, 3:30 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 25 2022, 3:30 PM

markj requested review of this revision.Oct 25 2022, 3:30 PM

Harbormaster completed remote builds in B47987: Diff 112185.Oct 25 2022, 3:30 PM

markj added a parent revision: D37116: bhyve: Remove an unused parameter from pci_nvme_append_iov_req().Oct 25 2022, 3:30 PM

markj added a child revision: D37118: bhyve: Fix an apparent pointer arithmetic bug in the xhci emulation.

corvink added a subscriber: corvink.Oct 26 2022, 5:16 AM

corvink added inline comments.

usr.sbin/bhyve/rfb.c
887–897	What do you think about my suggestion? It avoids nested ifs.

markj marked an inline comment as done.Oct 26 2022, 1:50 PM

markj added inline comments.

usr.sbin/bhyve/rfb.c
887–897	Thanks, that is better than what I did.

Restructure to reduce nesting.

Harbormaster completed remote builds in B48004: Diff 112209.Oct 26 2022, 1:50 PM

rew added a subscriber: rew.Oct 26 2022, 8:49 PM

rew added inline comments.

usr.sbin/bhyve/rfb.c
890	looks like this got crossed up on the previous update

Jump to the right label.

Harbormaster completed remote builds in B48014: Diff 112235.Oct 26 2022, 9:28 PM

jhb accepted this revision.Oct 26 2022, 9:32 PM

This revision is now accepted and ready to land.Oct 26 2022, 9:32 PM

Closed by commit rG04336c056248: bhyve: Make sure that the VNC version is initialized (authored by markj). · Explain WhyOct 27 2022, 2:50 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG04336c056248: bhyve: Make sure that the VNC version is initialized.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

rfb.c

7 lines

Diff 112252

View Options

bhyve: Make sure that the VNC version is initializedClosedPublicActions