Use `rm -fv` for BATCH_DELETE_OLD_FILES
ClosedPublic
Actions

Authored by emaste on Oct 24 2022, 6:10 PM.

Details

Reviewers

imp
brooks

Commits

rG689a5b194435: build: Use `rm -fv` for BATCH_DELETE_OLD_FILES
rG470fb726f3d2: build: Use `rm -fv` for BATCH_DELETE_OLD_FILES

Summary

It's possible to have files with odd permissions in the tmproot (or sysroot), causing rm to prompt for each one. Add -f to forcibly delete these.

Example:

override r--r--r-- emaste/wheel uarch for /usr/obj/usr/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/c++/v1/__functional_base? y
override r--r--r-- emaste/wheel uarch for /usr/obj/usr/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/c++/v1/__libcpp_version? y
override r--r--r-- emaste/wheel uarch for /usr/obj/usr/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/c++/v1/__nullptr? y
override r--r--r-- emaste/wheel uarch for /usr/obj/usr/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/include/c++/v1/__string? y

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Oct 24 2022, 6:10 PM

emaste created this revision.

Seems generally reasonable. Do we need to check afterwards to warn if they were not deleted?

This revision is now accepted and ready to land.Oct 25 2022, 2:54 AM

In D37111#842827, @brooks wrote:

Seems generally reasonable. Do we need to check afterwards to warn if they were not deleted?

The build will exit if rm fails, e.g.

>>> Deleting stale files in build tree...
rm: /usr/obj/usr/home/emaste/src/freebsd-git/wipbsd/amd64.amd64/sysroot/usr/tests/usr.sbin/pw/pw_lock: Operation not permitted

Closed by commit rG470fb726f3d2: build: Use `rm -fv` for BATCH_DELETE_OLD_FILES (authored by emaste). · Explain WhyOct 25 2022, 3:19 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG470fb726f3d2: build: Use `rm -fv` for BATCH_DELETE_OLD_FILES.

emaste added a commit: rG689a5b194435: build: Use `rm -fv` for BATCH_DELETE_OLD_FILES.Nov 19 2022, 7:12 PM