truss: remove now-unused special case for MIPS
ClosedPublic
Actions

Authored by emaste on Oct 17 2022, 5:20 PM.

Tags

None

Referenced Files

	F95892002: D37022.diff
	Sun, Sep 22, 11:23 PM

	Unknown Object (File)
	Sat, Sep 7, 3:53 AM

	Unknown Object (File)
	Thu, Sep 5, 7:44 PM

	Unknown Object (File)
	Thu, Sep 5, 4:58 AM

	Unknown Object (File)
	Aug 18 2024, 1:00 AM

	Unknown Object (File)
	Aug 4 2024, 2:20 PM

	Unknown Object (File)
	Jul 5 2024, 7:41 AM

	Unknown Object (File)
	Jun 24 2024, 11:25 AM

View All 29 Files

Subscribers

None

Details

Reviewers

arichardson
imp
mhorne

Commits

rG9a86a3cd9b4c: truss: remove now-unused special case for MIPS

Summary

Was introduced with 31dddc6a19042bad303cb3d3aa8f52a2cb22dd77. We could revert part of that commit instead (and inline user_ptr32_to_psaddr) but I think the fn serves some documentary purpose.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Oct 17 2022, 5:20 PM

emaste created this revision.

LGTM

This revision is now accepted and ready to land.Oct 17 2022, 5:44 PM

One comment, but either way this is a good change.

usr.bin/truss/syscalls.c
1560–1562	I think you can omit the second sentence.

emaste added inline comments.Oct 17 2022, 6:00 PM

usr.bin/truss/syscalls.c
1560–1562	Yeah, good point, although it's probably the "currently" that is superfluous. Maybe "Convert a 32-bit user-space pointer to psaddr_t by zero-extending."