Page MenuHomeFreeBSD

loader: fix elf lookup_symbol type filtering
ClosedPublic

Authored by kevans on Oct 13 2022, 2:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:35 PM
Unknown Object (File)
Oct 5 2024, 7:05 AM
Unknown Object (File)
Oct 2 2024, 11:04 AM
Unknown Object (File)
Oct 2 2024, 2:00 AM
Unknown Object (File)
Sep 30 2024, 4:23 PM
Unknown Object (File)
Sep 30 2024, 6:31 AM
Unknown Object (File)
Sep 30 2024, 4:23 AM
Unknown Object (File)
Sep 25 2024, 12:11 AM
Subscribers

Details

Summary

The existing logic doesn't seem to make much sense, as we won't filter
on the type if st_shndx != SHN_UNDEF. In practice, this breaks booting
12.3 kernels on newer loaders, as they do have a kernphys symbol of
the wrong type (NOTYPE, rather than OBJECT) -- we end up deriving the
wrong value for copy_staging.

It's unclear if this version makes any more sense, but it seems to match
what rtld's matched_symbol() does. Loader doesn't need to care about
STT_FUNC w/ UND shndx, because we won't encounter those; in kmods,
undefined (kernel) functions are NOTYPE.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable