Page MenuHomeFreeBSD
Differential D36966

linuxkpi: Add `cmpxchg64()` in <asm/atomic.h>
ClosedPublic
Actions

Authored by dumbbell on Oct 12 2022, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 22, 1:33 PM
Unknown Object (File)
Tue, Sep 17, 9:44 AM
Unknown Object (File)
Thu, Sep 5, 6:11 AM
Unknown Object (File)
Sun, Sep 1, 12:38 AM
Unknown Object (File)
Aug 2 2024, 3:11 AM
Unknown Object (File)
Jul 24 2024, 2:00 AM
Unknown Object (File)
Jul 23 2024, 11:50 PM
Unknown Object (File)
Jul 4 2024, 8:29 PM
View All 39 Files
Subscribers
emaste
• hselasky
imp
linuxkpi

Details

Reviewers
manu
Group Reviewers
linuxkpi
Commits
rGe279c1fcfafb: linuxkpi: Add `cmpxchg64()` in <asm/atomic.h>
rGe79a57d4ecb7: linuxkpi: Add `cmpxchg64()` in <asm/atomic.h>
Summary

I defined it as an alias to cmpxchg(), not sure it is correct...

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Oct 12 2022, 7:23 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 12 2022, 7:23 PM
dumbbell requested review of this revision.Oct 12 2022, 7:23 PM
Harbormaster completed remote builds in B47814: Diff 111736.Oct 12 2022, 7:23 PM
dumbbell mentioned this in D36869: This patch contains [[ https://github.com/dumbbell/freebsd-src/tree/linuxkpi-changes-for-drm-from-5.11 | a series of commits to linuxkpi ]] in order to support an update of the DRM drivers to match Linux 5.11:.Oct 12 2022, 7:32 PM
dumbbell added a comment.Oct 12 2022, 7:36 PM

I'm not sure about making cmpxchg64() an alias of cmpxchg(). It will probably break on 32bit archs.

manu added a comment.Oct 14 2022, 8:35 AM
In D36966#839564, @dumbbell wrote:

I'm not sure about making cmpxchg64() an alias of cmpxchg(). It will probably break on 32bit archs.

I think so too.

manu added a reviewer: linuxkpi.Oct 14 2022, 8:35 AM
• hselasky added a subscriber: • hselasky.Oct 16 2022, 1:00 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/asm/atomic.h
221

It's only defined for selected platforms. And will compile time assert if not present!

Should be OK.

manu accepted this revision.Dec 1 2022, 1:26 PM
manu added inline comments.
sys/compat/linuxkpi/common/include/asm/atomic.h
221

Yes indeed.

This revision is now accepted and ready to land.Dec 1 2022, 1:26 PM
Closed by commit rGe79a57d4ecb7: linuxkpi: Add `cmpxchg64()` in <asm/atomic.h> (authored by dumbbell, committed by manu). · Explain WhyDec 1 2022, 2:05 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGe79a57d4ecb7: linuxkpi: Add `cmpxchg64()` in <asm/atomic.h>.
manu added a commit: rGe279c1fcfafb: linuxkpi: Add `cmpxchg64()` in <asm/atomic.h>.Jan 24 2023, 8:56 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
asm/
1 line

Diff 113745

View Options

sys/compat/linuxkpi/common/include/asm/atomic.h

Loading...