Page MenuHomeFreeBSD
Differential D36961

linuxkpi: Add <linux/page-flags.h>
ClosedPublic
Actions

Authored by dumbbell on Oct 12 2022, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 4:26 PM
Unknown Object (File)
Oct 1 2024, 1:56 PM
Unknown Object (File)
Sep 27 2024, 5:45 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 26 2024, 11:27 AM
View All 36 Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
manu
Commits
rGcec94450c299: linuxkpi: Add <linux/page-flags.h>
rG708a570255a4: linuxkpi: Add <linux/page-flags.h>
Summary

It just provides a PageHighMem() macro stub.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47809
Build 44696: arc lint + arc unit

Event Timeline

dumbbell created this revision.Oct 12 2022, 7:18 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 12 2022, 7:18 PM
dumbbell requested review of this revision.Oct 12 2022, 7:18 PM
Harbormaster completed remote builds in B47809: Diff 111731.Oct 12 2022, 7:18 PM
dumbbell mentioned this in D36869: This patch contains [[ https://github.com/dumbbell/freebsd-src/tree/linuxkpi-changes-for-drm-from-5.11 | a series of commits to linuxkpi ]] in order to support an update of the DRM drivers to match Linux 5.11:.Oct 12 2022, 7:32 PM
manu added inline comments.Oct 14 2022, 8:38 AM
sys/compat/linuxkpi/common/include/linux/page-flags.h
7

Are those copyrights correct ?

dumbbell updated this revision to Diff 112655.Nov 5 2022, 2:02 PM

Remove copy-pasted copyright statements.

dumbbell marked an inline comment as done.Nov 5 2022, 2:02 PM
manu added inline comments.Nov 5 2022, 5:18 PM
sys/compat/linuxkpi/common/include/linux/page-flags.h
3

I think that this SPDX isn't correct even if it's in the template, @imp ?
Also you might want to add yourself as the copyright holder or put the file in public domain, I don't think that BSD-2-Clause without ownership make sense.

manu mentioned this in D36970: linuxkpi: Add <linux/mman.h> which includes <linux/smp.h>.Nov 5 2022, 5:19 PM
emaste added inline comments.Nov 5 2022, 8:45 PM
sys/compat/linuxkpi/common/include/linux/page-flags.h
3

Right, just BSD-2-Clause

imp added inline comments.Nov 5 2022, 9:23 PM
sys/compat/linuxkpi/common/include/linux/page-flags.h
3

I just updated the licensing files.
BSD-2-Clause-FreeBSD was approved and then deprecated by SPDX for reasons too long to go into here.
The project's current use of it is largely in error, but the resources to correct this error haven't been found.
This applies to all the different places manu@ has flagged.
You also have the option to omit the actual license text now.

dumbbell updated this revision to Diff 112962.Nov 11 2022, 6:09 PM
  • Fix SPDX identifier
  • Add copyright line
dumbbell marked 3 inline comments as done.Nov 11 2022, 6:10 PM
manu accepted this revision.Nov 11 2022, 7:48 PM
This revision is now accepted and ready to land.Nov 11 2022, 7:48 PM
Closed by commit rG708a570255a4: linuxkpi: Add <linux/page-flags.h> (authored by dumbbell). · Explain WhyNov 11 2022, 8:05 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rG708a570255a4: linuxkpi: Add <linux/page-flags.h>.
manu added a commit: rGcec94450c299: linuxkpi: Add <linux/page-flags.h>.Jan 24 2023, 8:56 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
37 lines

Diff 111731

View Options

sys/compat/linuxkpi/common/include/linux/page-flags.h

Loading...