param.h
ClosedPublic
Actions

Authored by imp on Oct 10 2022, 5:21 PM.

Details

Reviewers

jhb
tsoome

Commits

rGaa62d30d46f7: sys/_pv_entry.h: Include sys/param.h

Summary

sys/param.h is required for this file because it uses howmany() which is
defined there. For the kernel, this works today because of namespace
polllution. However, user land programs, like qemu, can include
machine/pmap.h without having included sys/param.h (since it wasn't
required before).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 10 2022, 5:21 PM

imp created this revision.

imp added a reviewer: jhb.Oct 10 2022, 5:22 PM

Harbormaster completed remote builds in B47767: Diff 111616.Oct 10 2022, 5:22 PM

tsoome accepted this revision.Oct 11 2022, 2:29 PM

This revision is now accepted and ready to land.Oct 11 2022, 2:29 PM

Wasn't qemu already patched? This header didn't add the howmany, it just moved it. I thought the equivalent of D36362 was already merged to the port, so it shouldn't be broken? Is there anything other than qemu that uses this header? Last time that was the only report of breakage I received.

In D36927#838836, @jhb wrote:

Wasn't qemu already patched? This header didn't add the howmany, it just moved it. I thought the equivalent of D36362 was already merged to the port, so it shouldn't be broken? Is there anything other than qemu that uses this header? Last time that was the only report of breakage I received.

QEMU upstream wasn't patched (just the port), and it's a lot easier for me to fix it here than in upstream due its heavyweight process.

jhb accepted this revision.Oct 11 2022, 5:52 PM

Closed by commit rGaa62d30d46f7: sys/_pv_entry.h: Include sys/param.h (authored by imp). · Explain WhyOct 11 2022, 6:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGaa62d30d46f7: sys/_pv_entry.h: Include sys/param.h.