nvme: Always set deadline to max
ClosedPublic
Actions

Authored by imp on Oct 10 2022, 2:15 AM.

Details

Reviewers

mav
chs
chuck

Commits

rG4982884b99e8: nvme: Always set deadline to max

Summary

The deadline always needs to be valid, and not what's left over from before.
Always initialize it to maximum.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47757
Build 44644: arc lint + arc unit

Event Timeline

imp created this revision.Oct 10 2022, 2:15 AM

Herald added a subscriber: dab. · View Herald TranscriptOct 10 2022, 2:15 AM

imp requested review of this revision.Oct 10 2022, 2:15 AM

Harbormaster completed remote builds in B47757: Diff 111598.Oct 10 2022, 2:15 AM

imp added a child revision: D36921: nvme: Timeout expired transactions.Oct 10 2022, 2:15 AM

imp added reviewers: mav, chs, chuck.Oct 10 2022, 2:18 AM

Since it is under the queue lock I don't see much difference in the order, only removal of the condition makes sense to me.

This revision is now accepted and ready to land.Oct 10 2022, 1:43 PM

imp edited the summary of this revision. (Show Details)Oct 10 2022, 10:37 PM

simplify code and re-word commit message about what's really important here.

This revision now requires review to proceed.Oct 10 2022, 10:38 PM

Harbormaster completed remote builds in B47770: Diff 111627.Oct 10 2022, 10:38 PM

mav accepted this revision.Oct 11 2022, 2:33 PM

This revision is now accepted and ready to land.Oct 11 2022, 2:33 PM

Closed by commit rG4982884b99e8: nvme: Always set deadline to max (authored by imp). · Explain WhyOct 11 2022, 6:58 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4982884b99e8: nvme: Always set deadline to max.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_qpair.c

8 lines

Diff 111598

View Options

nvme: Always set deadline to maxClosedPublicActions