Page MenuHomeFreeBSD

tcp: restore some memory savings associated with TIME_WAIT state
AcceptedPublic

Authored by glebius on Oct 5 2022, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 6:19 PM
Unknown Object (File)
Oct 2 2024, 2:40 PM
Unknown Object (File)
Sep 25 2024, 4:14 PM
Unknown Object (File)
Sep 25 2024, 4:14 PM
Unknown Object (File)
Sep 25 2024, 4:14 PM
Unknown Object (File)
Sep 25 2024, 4:03 PM
Unknown Object (File)
Sep 22 2024, 6:30 PM
Unknown Object (File)
Sep 4 2024, 4:32 AM
Subscribers

Details

Reviewers
rrs
Group Reviewers
transport
Summary

Although with XXXXXX we no longer reallocate tcpcb to tcptw, we are still
interested in not wasting extra memory while a connection waits for 2MSL
timeout.

  • In tcp_twstart() when transitioning to TIME_WAIT, if the file descriptor had been closed, let's free the socket and contexts that hang off the socket (e.g. kTLS context).
  • In tcp_usr_detach() differentiate this case by absence of INP_DROPPED flag and don't free the pcb.
  • After the 2MSL timeout in tcp_close() differentiate a pcb that has been left by tcp_usr_detach() by checking that inp_socket pointer is NULL.
  • Go around the code touched by XXXXXX and restore safety checks for a connection in TIME_WAIT state. Previously we were guarding against dereferencing inp_ppcb as tcptw, now we are guarding against dereferencing inp_socket.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47701
Build 44588: arc lint + arc unit