Page MenuHomeFreeBSD
Differential D36871

msk: Don't bother reading spare stats registers.
ClosedPublic
Actions

Authored by jhb on Oct 3 2022, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 20, 7:45 AM
Unknown Object (File)
Thu, Sep 19, 10:15 PM
Unknown Object (File)
Mon, Sep 16, 6:22 PM
Unknown Object (File)
Thu, Sep 12, 4:13 PM
Unknown Object (File)
Thu, Sep 12, 4:13 PM
Unknown Object (File)
Sat, Sep 7, 5:40 AM
Unknown Object (File)
Fri, Sep 6, 6:12 AM
Unknown Object (File)
Fri, Sep 6, 2:33 AM
View All 40 Files
Subscribers
None

Details

Reviewers
emaste
imp
Commits
rGd77e67e9d5e4: msk: Don't bother reading spare stats registers.
rGaabbe26939be: msk: Don't bother reading spare stats registers.
Summary

msk_stats_update reads stats registers named "spare" whose values are
discarded.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47685
Build 44572: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Oct 3 2022, 11:21 PM
jhb created this revision.
Harbormaster completed remote builds in B47685: Diff 111399.Oct 3 2022, 11:21 PM
jhb added a child revision: D36777: msk: Use a void cast to mark values of dummy reads as unused..Oct 3 2022, 11:22 PM
emaste accepted this revision.Oct 4 2022, 1:02 PM

I suppose it's possible some incredibly poorly designed hardware could require that all of the registers be read, but I'm sure that's not the case here.

This revision is now accepted and ready to land.Oct 4 2022, 1:02 PM
imp accepted this revision.Oct 4 2022, 7:31 PM
Closed by commit rGaabbe26939be: msk: Don't bother reading spare stats registers. (authored by jhb). · Explain WhyOct 5 2022, 11:48 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGaabbe26939be: msk: Don't bother reading spare stats registers..
jhb added a commit: rGd77e67e9d5e4: msk: Don't bother reading spare stats registers..Nov 11 2022, 6:39 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
msk/
4 lines

Diff 111399

View Options

sys/dev/msk/if_msk.c

Loading...