siftr: apply filter early on
ClosedPublic
Actions

Authored by rscheff on Sep 30 2022, 4:54 PM.

Details

Reviewers

tuexen
glebius
cc

Group Reviewers

transport

Commits

rG9c6558383546: siftr: apply filter early on

Summary

Move the port filter to quickly check TCP ports early on,
before investing into expensive operations such as reinject
checking and locating the INP.

No functional change.

Obtained from: guest-ccui
Sponsored by: NetApp, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47662
Build 44549: arc lint + arc unit

Event Timeline

rscheff created this revision.Sep 30 2022, 4:54 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 30 2022, 4:54 PM

rscheff requested review of this revision.Sep 30 2022, 4:54 PM

Harbormaster completed remote builds in B47661: Diff 111281.Sep 30 2022, 4:54 PM

rscheff added a reviewer: cc.Sep 30 2022, 4:57 PM

rscheff added a subscriber: cc.

cc requested changes to this revision.Sep 30 2022, 5:03 PM

cc added inline comments.

sys/netinet/siftr.c
869	Sorry, my bad. Forgot to switch back to "th->th_sport" and "th->th_dport".
1055	Same here. Switch to "th->th_sport" and "th->th_dport".

This revision now requires changes to proceed.Sep 30 2022, 5:03 PM

fix copy error

Harbormaster completed remote builds in B47662: Diff 111282.Sep 30 2022, 5:14 PM

Looks good. Thanks.

tuexen accepted this revision.Oct 7 2022, 12:20 PM

This revision is now accepted and ready to land.Oct 7 2022, 12:20 PM

Closed by commit rG9c6558383546: siftr: apply filter early on (authored by rscheff). · Explain WhyOct 7 2022, 2:56 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG9c6558383546: siftr: apply filter early on.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

siftr.c

70 lines

Diff 111282

View Options

siftr: apply filter early onClosedPublicActions