GCC 12 warns that passing "" (a constant of char[1]) to a parameter of
type char[33] could potentially overread. It is not clear from the
context that c->qops can never be "auth-int" (and if it can't, then
the "auth-int" handling in DigestCalcResponse is dead code that should
be removed since this is the only place the function is called).
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 47639 Build 44526: arc lint + arc unit
Event Timeline
Comment Actions
@des Thanks for adding me to the review, but the code for HTTP digest authentication was contributed by Jean-Francois Dockes <jf@dockes.org> (I contributed code in the area of TLS and certificates).