Page MenuHomeFreeBSD

zlib crc32: Add prototypes for recently-added static functions.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 5:03 AM
Unknown Object (File)
Sat, Nov 2, 4:53 AM
Unknown Object (File)
Sep 28 2024, 8:11 PM
Unknown Object (File)
Sep 28 2024, 8:10 PM
Unknown Object (File)
Sep 28 2024, 11:04 AM
Unknown Object (File)
Sep 28 2024, 10:59 AM
Unknown Object (File)
Sep 27 2024, 10:39 AM
Unknown Object (File)
Sep 25 2024, 2:36 AM
Subscribers
None

Details

Summary

This appeases -Wstrict-prototypes with GCC. Using a separate
prototype using the OF macro seems to be consistent with the rest of
this file which still supports pre-ANSI C.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47570
Build 44457: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:42 PM
jhb created this revision.

Should these also be upstreamed?

This revision is now accepted and ready to land.Sep 27 2022, 6:17 PM

There's a bigger question of what to do w/ zlib upstream with K&R, so it seems fine to make this change in our tree now and separately try to tackle all of that together.