Page MenuHomeFreeBSD

LinuxKPI: add the "dummy" includes directory to builds
ClosedPublic

Authored by bz on Sep 23 2022, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:40 AM
Unknown Object (File)
Wed, Mar 19, 1:33 PM
Unknown Object (File)
Thu, Mar 6, 7:34 AM
Unknown Object (File)
Wed, Mar 5, 11:54 PM
Unknown Object (File)
Feb 23 2025, 1:12 AM
Unknown Object (File)
Feb 15 2025, 1:01 AM
Unknown Object (File)
Feb 14 2025, 10:29 PM
Unknown Object (File)
Feb 11 2025, 5:03 AM
Subscribers

Details

Summary

While we could add the summy includes directory manually to only the
drivers needing it, it seems a lot easier to simply add it to all
without any expected harm.

This is needed for more drivers (and to remove some #ifdef in current
ones) with empty header files being present not yielding errors.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Sep 23 2022, 9:29 PM
hselasky added inline comments.
sys/conf/kern.pre.mk
296–297

use "\" here to break long line?

This revision is now accepted and ready to land.Sep 23 2022, 9:32 PM

Break the long line though in this file long lines are common.

This revision now requires review to proceed.Sep 23 2022, 9:40 PM
bz marked an inline comment as done.Sep 23 2022, 9:40 PM
This revision is now accepted and ready to land.Sep 23 2022, 9:46 PM

All LinuxKPI drivers should get this, I agree. And I think these changes do the right thing wrt that.

Is here a comment somewhere about what the linuxpki/dummy/include directory does or what purpose it serves?
If not, now might be a good time to add one.

Also, kmod.mk (or is that kern.mk) is included for all kernel builds, I think, so you might not need this in two places, but that's a pre-existing problem. the whole kern.pre.mk, kern.post.mk and kern.mk mess needs to be reworked, which is definitely not your problem...