Differential D36535

qcom_qup: compilation fixes
ClosedPublic
Actions

Authored by adrian on Sep 12 2022, 6:37 AM.

Details

Reviewers

imp

Commits

rG633d178c63be: qcom_qup: compilation fixes

Summary

Fix compilation warning/errors - in this instance we do need the register
IO.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47348
Build 44235: arc lint + arc unit

Event Timeline

adrian created this revision.Sep 12 2022, 6:37 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 12 2022, 6:37 AM

adrian requested review of this revision.Sep 12 2022, 6:37 AM

adrian added a parent revision: D36534: qcom_tlmm: fix compiler errors, return error code.

Harbormaster completed remote builds in B47337: Diff 110460.Sep 12 2022, 6:37 AM

imp added inline comments.Sep 12 2022, 1:26 PM

sys/dev/qcom_qup/qcom_spi_hw.c
730	I don't think you need (void) here.

address comments from imp

Harbormaster completed remote builds in B47342: Diff 110469.Sep 12 2022, 6:28 PM

update

Harbormaster completed remote builds in B47348: Diff 110475.Sep 12 2022, 6:31 PM

imp accepted this revision.Sep 12 2022, 6:36 PM

This revision is now accepted and ready to land.Sep 12 2022, 6:36 PM

Closed by commit rG633d178c63be: qcom_qup: compilation fixes (authored by adrian). · Explain WhySep 13 2022, 3:11 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG633d178c63be: qcom_qup: compilation fixes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

qcom_qup/

qcom_spi_hw.c

4 lines

Diff 110475

View Options

sys/dev/qcom_qup/qcom_spi_hw.c

qcom_qup: compilation fixesClosedPublicActions