Page MenuHomeFreeBSD

veriexec: fixed usage and getopt issue on armv6
ClosedPublic

Authored by sebastien.bini_stormshield.eu on Sep 7 2022, 8:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 4 2024, 9:02 PM
Unknown Object (File)
Oct 4 2024, 4:02 AM
Unknown Object (File)
Oct 3 2024, 10:26 AM
Unknown Object (File)
Oct 1 2024, 3:17 PM
Unknown Object (File)
Sep 24 2024, 6:53 AM
Unknown Object (File)
Sep 5 2024, 2:48 PM
Unknown Object (File)
Aug 11 2024, 3:39 PM
Unknown Object (File)
Aug 10 2024, 9:12 AM
Subscribers

Details

Reviewers
wma
mw
imp
Summary

This fixes an issue introduced by https://reviews.freebsd.org/D33246

getopt returns an int, which was stored inside c of type char. c was then compared to -1. All those type conversions worked fine on our amd64 systems, but not on armv6 architecture.

The -1 returned by getopt, stored in c, never successfully compared to -1, causing the program to fall into the usage error in the default: switch case.

I also fixed the usage function, as -C takes a path as parameter.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47276
Build 44163: arc lint + arc unit