Page MenuHomeFreeBSD
Differential D36411

net80211: simplify an #ifdef INET/INET6 block
ClosedPublic
Actions

Authored by bz on Aug 31 2022, 10:39 PM.
Tags
None
Referenced Files
F102428176: D36411.diff
Tue, Nov 12, 3:33 AM
F102379177: D36411.diff
Mon, Nov 11, 11:22 AM
Unknown Object (File)
Mon, Nov 11, 2:01 AM
Unknown Object (File)
Thu, Nov 7, 7:37 AM
Unknown Object (File)
Tue, Nov 5, 8:42 PM
Unknown Object (File)
Thu, Oct 17, 3:02 PM
Unknown Object (File)
Wed, Oct 16, 3:36 AM
Unknown Object (File)
Mon, Oct 14, 11:28 PM
View All 75 Files
Subscribers
glebius
imp
melifaro
zlei

Details

Reviewers
zlei
Group Reviewers
wireless
Commits
rGb1a57b105ce6: net80211: simplify an #ifdef INET/INET6 block
rG8def06d5afdc: net80211: simplify an #ifdef INET/INET6 block
Summary

I got lost in the #ifdef #endif here so I checked the code to a
switch block with two non-overlapping #ifdef parts and a default
which makes it a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 5 days

Test Plan

I would highly appreciate if people would carefully
double-check that I manually change-ifdefed it correctly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47228
Build 44115: arc lint + arc unit

Event Timeline

bz created this revision.Aug 31 2022, 10:39 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptAug 31 2022, 10:39 PM
bz requested review of this revision.Aug 31 2022, 10:39 PM
Harbormaster completed remote builds in B47213: Diff 110028.Aug 31 2022, 10:39 PM
zlei added a subscriber: zlei.Sep 2 2022, 1:12 AM
zlei added inline comments.
sys/net80211/ieee80211_output.c
1289–1291

Missing break here.

1307

ditto

bz updated this revision to Diff 110071.Sep 2 2022, 1:57 AM

Add missing breaks. Thank you for care fully checking! :)

Harbormaster completed remote builds in B47228: Diff 110071.Sep 2 2022, 1:57 AM
bz marked 2 inline comments as done.Sep 2 2022, 1:57 AM
zlei accepted this revision.Sep 2 2022, 3:58 AM

Looks good to me.

This revision is now accepted and ready to land.Sep 2 2022, 3:58 AM
Closed by commit rG8def06d5afdc: net80211: simplify an #ifdef INET/INET6 block (authored by bz). · Explain WhySep 3 2022, 9:02 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG8def06d5afdc: net80211: simplify an #ifdef INET/INET6 block.
bz added a commit: rGb1a57b105ce6: net80211: simplify an #ifdef INET/INET6 block.Sep 21 2022, 2:04 PM

Revision Contents
Changeset List

PathSize
sys/
net80211/
27 lines

Diff 110071

View Options

sys/net80211/ieee80211_output.c

Loading...