Page MenuHomeFreeBSD

net80211: simplify an #ifdef INET/INET6 block
ClosedPublic

Authored by bz on Aug 31 2022, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 7:43 PM
Unknown Object (File)
Dec 10 2024, 12:47 PM
Unknown Object (File)
Nov 26 2024, 1:38 AM
Unknown Object (File)
Nov 23 2024, 12:27 PM
Unknown Object (File)
Nov 22 2024, 9:47 PM
Unknown Object (File)
Nov 20 2024, 8:53 PM
Unknown Object (File)
Nov 20 2024, 12:56 PM
Unknown Object (File)
Nov 13 2024, 9:06 PM

Details

Summary

I got lost in the #ifdef #endif here so I checked the code to a
switch block with two non-overlapping #ifdef parts and a default
which makes it a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 5 days

Test Plan

I would highly appreciate if people would carefully
double-check that I manually change-ifdefed it correctly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47228
Build 44115: arc lint + arc unit

Event Timeline

bz requested review of this revision.Aug 31 2022, 10:39 PM
zlei added inline comments.
sys/net80211/ieee80211_output.c
1289–1291

Missing break here.

1307

ditto

Add missing breaks. Thank you for care fully checking! :)

bz marked 2 inline comments as done.Sep 2 2022, 1:57 AM
This revision is now accepted and ready to land.Sep 2 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.