Page MenuHomeFreeBSD

net80211: simplify an #ifdef INET/INET6 block
ClosedPublic

Authored by bz on Aug 31 2022, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 10:51 PM
Unknown Object (File)
Tue, Mar 18, 6:52 PM
Unknown Object (File)
Feb 23 2025, 9:02 AM
Unknown Object (File)
Feb 18 2025, 9:11 AM
Unknown Object (File)
Feb 8 2025, 7:37 AM
Unknown Object (File)
Jan 24 2025, 5:49 PM
Unknown Object (File)
Jan 16 2025, 7:00 AM
Unknown Object (File)
Jan 16 2025, 6:47 AM

Details

Summary

I got lost in the #ifdef #endif here so I checked the code to a
switch block with two non-overlapping #ifdef parts and a default
which makes it a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 5 days

Test Plan

I would highly appreciate if people would carefully
double-check that I manually change-ifdefed it correctly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Aug 31 2022, 10:39 PM
zlei added inline comments.
sys/net80211/ieee80211_output.c
1289–1291

Missing break here.

1307

ditto

Add missing breaks. Thank you for care fully checking! :)

bz marked 2 inline comments as done.Sep 2 2022, 1:57 AM
This revision is now accepted and ready to land.Sep 2 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.