Fix TCP state states when TFO is used
ClosedPublic
Actions

Authored by tuexen on Aug 28 2022, 10:12 AM.

Details

Reviewers

rrs
glebius
rscheff

Group Reviewers

transport

Commits

rGa18afeac4902: tcp: fix stats counter for SYN_RCVD state when TCP-FO is used
rGc624b9a549f0: tcp: fix stats counter for SYN_RCVD state when TCP-FO is used

Summary

This patch fixes the stat counter for the SYN_RCVD state when TCP fast open is used successfully. Without this patch the corresponding counter gets negative as shown by netstat -sptcp.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Aug 28 2022, 10:12 AM

Herald added a reviewer: transport. · View Herald TranscriptAug 28 2022, 10:12 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Aug 28 2022, 10:12 AM

tuexen edited the summary of this revision. (Show Details)Aug 28 2022, 10:15 AM

My bad, missed the TFO case. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 28 2022, 5:07 PM

Closed by commit rGc624b9a549f0: tcp: fix stats counter for SYN_RCVD state when TCP-FO is used (authored by tuexen). · Explain Why

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGc624b9a549f0: tcp: fix stats counter for SYN_RCVD state when TCP-FO is used.

tuexen added a commit: rGa18afeac4902: tcp: fix stats counter for SYN_RCVD state when TCP-FO is used.Feb 1 2023, 11:34 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_syncache.c

1 line

Diff 109929

View Options

sys/netinet/tcp_syncache.c

Fix TCP state states when TFO is usedClosedPublicActions