Page MenuHomeFreeBSD

linuxolator: add netlink support
ClosedPublic

Authored by melifaro on Aug 26 2022, 2:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 3:17 PM
Unknown Object (File)
Fri, Oct 25, 4:38 AM
Unknown Object (File)
Fri, Oct 18, 12:34 AM
Unknown Object (File)
Thu, Oct 17, 11:14 PM
Unknown Object (File)
Thu, Oct 17, 5:40 PM
Unknown Object (File)
Thu, Oct 17, 3:07 AM
Unknown Object (File)
Mon, Oct 14, 10:25 PM
Unknown Object (File)
Sun, Oct 13, 5:32 PM
Subscribers

Details

Summary

Compat part for running Linux binaries with Netlink ( D36002 ).

Test Plan

Please see testing section in D36002.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47241
Build 44128: arc lint + arc unit

Event Timeline

melifaro edited the summary of this revision. (Show Details)
melifaro edited the test plan for this revision. (Show Details)
melifaro added a reviewer: Linux Emulation.

mostly style, thank you! tested with 2.35 glibc tests suite, inet tests completed!

sys/compat/linux/linux_netlink.c
31

I suggest to add an empty line here

60

style, blank line, and in many functions below

120

unnecessary parentheses

130

the same here

166

may be use return (netlink_family != NETLINK_ROUTE ? hdr :
rtnl_from_linux(hdr, npt));
?

183

blank line

185

if (out_hdr != NULL)

		memcpy(out_hdr, hdr, hdr->nlmsg_len);

return (out_hdr != NULL);

?

218

the same as above

234

unnecessary parentheses

385

unnecessary parentheses

This revision is now accepted and ready to land.Sep 8 2022, 8:35 AM

Update to reflect netlink KPI changes.

This revision now requires review to proceed.Sep 11 2022, 6:58 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2022, 2:20 PM
This revision was automatically updated to reflect the committed changes.