bhyve virtio-scsi: Tidy warning and debug prints.
ClosedPublic
Actions

Authored by jhb on Aug 19 2022, 11:42 PM.

Details

Reviewers

mav
emaste

Group Reviewers

bhyve

Commits

rGffbe54c2175c: bhyve virtio-scsi: Tidy warning and debug prints.
rG597a39a77132: bhyve virtio-scsi: Tidy warning and debug prints.
rG62806a7f31e3: bhyve virtio-scsi: Tidy warning and debug prints.

Summary

Use a consistent prefix ("virtio-scsi: ") similar to the e1000 device
model.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47028
Build 43917: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 19 2022, 11:42 PM

Herald added a reviewer: bhyve. · View Herald TranscriptAug 19 2022, 11:42 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Aug 19 2022, 11:42 PM

Harbormaster completed remote builds in B47028: Diff 109577.Aug 19 2022, 11:42 PM

jhb added a child revision: D36271: bhyve virtio-scsi: Avoid out of bounds accesses to guest requests..Aug 19 2022, 11:42 PM

freqlabs added inline comments.Aug 20 2022, 1:09 PM

usr.sbin/bhyve/pci_virtio_scsi.c
529	Left "pci_virtio_scsi: " on this one

Looks good to me, considering Ryan's comment.

This revision is now accepted and ready to land.Aug 20 2022, 8:38 PM

jhb marked an inline comment as done.Aug 29 2022, 5:06 PM

Fix a nit noticed by Ryan.

This revision now requires review to proceed.Aug 29 2022, 5:13 PM

Harbormaster completed remote builds in B47174: Diff 109967.Aug 29 2022, 5:13 PM

emaste accepted this revision.Aug 29 2022, 5:45 PM

This revision is now accepted and ready to land.Aug 29 2022, 5:45 PM

Closed by commit rG62806a7f31e3: bhyve virtio-scsi: Tidy warning and debug prints. (authored by jhb). · Explain WhyAug 29 2022, 10:39 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG62806a7f31e3: bhyve virtio-scsi: Tidy warning and debug prints..

jhb added a commit: rG597a39a77132: bhyve virtio-scsi: Tidy warning and debug prints..Nov 11 2022, 1:24 AM

jhb added a commit: rGffbe54c2175c: bhyve virtio-scsi: Tidy warning and debug prints..

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_virtio_scsi.c

22 lines

Diff 109577

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

bhyve virtio-scsi: Tidy warning and debug prints.ClosedPublicActions