This patch does code refactoring for existing rk_gpio driver:
It supports gpio type checking. Depending on gpio type some
register addresses are different.
Submitted by: @sos
Details
Details
- Reviewers
manu - Commits
- rG901df07a4768: Code refactoring for existing rk_gpio driver.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/arm64/rockchip/rk_gpio.c | ||
---|---|---|
275 | The problem with this approch is that we take the lock, read, release the lock, re-take the lock, read, re-release the lock. | |
404 | We have to take the lock before as we don't want another call to this function that will modify swporta_ddr too. | |
438 | Same as above, we want a lock here. | |
457 | Same as above. | |
475 | Same as above, we take the lock twice, add some unlocked version of those new function. |