Page MenuHomeFreeBSD

xen/timer: rename "timer.c" to "xen_timer.c"
ClosedPublic

Authored by ehem_freebsd_m5p.com on Aug 19 2022, 4:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 4:28 AM
Unknown Object (File)
Tue, Oct 29, 12:57 PM
Unknown Object (File)
Thu, Oct 10, 2:12 PM
Unknown Object (File)
Thu, Oct 10, 2:12 PM
Unknown Object (File)
Thu, Oct 10, 2:12 PM
Unknown Object (File)
Thu, Oct 10, 1:48 PM
Unknown Object (File)
Oct 9 2024, 12:29 PM
Unknown Object (File)
Sep 27 2024, 10:35 PM
Subscribers

Details

Summary

The better to avoid conflicting with other files given how "timer.c"
isn't a very unique name. ARM and RISC-V both have timer.c files.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can dump this on favored git repository sites if desired (https://gitlab.com/ehem/freebsd-src.git or https://github.com/ehem/freebsd-src.git branch would match the differential number).

It would be handy if @cperciva or @imp could accept and commit, since I already seem to be overloading @royger with patches. Pretty simple filename collision. Right now there aren't plans to get FreeBSD/Xen on RISC-V or ARM32, but steps have been taken to make those as easy as possible. ARM32 seems unlikely, but RISC-V looks quite likely in the future.

I was expecting this would happen sooner or later, TBH I was waiting for a real clash to happen before doing the renaming. I assume you now need to use parts of this file on Arm?

This revision is now accepted and ready to land.Aug 20 2022, 1:20 PM

FWIW xen_time.c might be slightly better, because it contains the code for the event timer, but also the time counter and the system clock.

You will also need to update the folder name in that case

I'm agnostic on royger's suggestion.
I note there's a number of other similar files as well, like debug.c..

This revision was automatically updated to reflect the committed changes.