o Assert that every protosw has pr_attach. Now this structure is
only for socket protocols declarations and nothing else.
o Merge struct pr_usrreqs into struct protosw. This was suggested
in 1996 by wollman@ (see 7b187005d18ef), and later reiterated
in 2006 by rwatson@ (see 6fbb9cf860dcd).
o Make struct domain hold a variable sized array of protosw pointers.
For most protocols these pointers are initialized statically.
Those domains that may have loadable protocols have spacers. IPv4
and IPv6 have 8 spacers each (andre@ dff3237ee54ea).
o For inetsw and inet6sw leave a comment noting that many protosw
entries very likely are dead code.
o Refactor pf_proto_[un]register() into protow_[un]register().
o Isolate pr_*_notsupp() methods into uipc_domain.c
Details
Details
- Reviewers
melifaro - Group Reviewers
network transport - Commits
- rGe7d02be19d40: protosw: refactor protosw and domain static declaration and load
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Warnings Severity Location Code Message Warning sys/compat/linuxkpi/common/include/linux/net.h:61 SPELL1 Possible Spelling Mistake Warning sys/compat/linuxkpi/common/include/linux/net.h:63 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:81 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:93 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:99 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:106 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:112 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:144 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_domain.c:196 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_socket.c:921 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_socket.c:932 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_socket.c:1328 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_socket.c:1362 SPELL1 Possible Spelling Mistake Warning sys/kern/uipc_socket.c:1364 SPELL1 Possible Spelling Mistake Warning sys/sys/protosw.h:244 SPELL1 Possible Spelling Mistake - Unit
No Test Coverage - Build Status
Buildable 46977 Build 43866: arc lint + arc unit