Page MenuHomeFreeBSD

bhyve nvme: Support minimal Controller list
ClosedPublic

Authored by chuck on Aug 13 2022, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 10:34 PM
Unknown Object (File)
Tue, Sep 24, 6:15 AM
Unknown Object (File)
Tue, Sep 17, 6:07 PM
Unknown Object (File)
Tue, Sep 17, 1:54 PM
Unknown Object (File)
Mon, Sep 16, 9:07 PM
Unknown Object (File)
Mon, Sep 16, 7:51 AM
Unknown Object (File)
Sat, Sep 7, 9:28 AM
Unknown Object (File)
Thu, Sep 5, 11:50 AM
Subscribers

Details

Summary

Controllers must support the Identify Controller list if they support
Namespace Management. But the UNH NVMe tests use this command regardless
of whether the device under test supports Namespace Management.

This implementation returns an empty Controller list (i.e., Number of
Identifiers is zero).

Fixes UNH Test 1.1.2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck requested review of this revision.Aug 13 2022, 3:39 PM
This revision is now accepted and ready to land.Aug 15 2022, 6:52 PM
usr.sbin/bhyve/pci_nvme.c
1579

For new code I prefer memset since it is POSIX unlike bzero.

This revision now requires review to proceed.Aug 16 2022, 3:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 16 2022, 4:17 PM
This revision was automatically updated to reflect the committed changes.