Page MenuHomeFreeBSD
Differential D36140

ipfw: make it possible to specify MTU for "unreach needfrag" action
ClosedPublic
Actions

Authored by glebius on Aug 11 2022, 2:29 PM.
Tags
None
Referenced Files
F107583712: D36140.diff
Thu, Jan 16, 5:54 AM
Unknown Object (File)
Dec 9 2024, 3:45 AM
Unknown Object (File)
Oct 18 2024, 12:41 PM
Unknown Object (File)
Oct 18 2024, 12:41 PM
Unknown Object (File)
Oct 18 2024, 12:39 PM
Unknown Object (File)
Oct 3 2024, 3:49 AM
Unknown Object (File)
Sep 25 2024, 7:00 AM
Unknown Object (File)
Sep 14 2024, 5:43 PM
View All 80 Files
Subscribers
donner
imp
pauamma_gundo.com

Details

Reviewers
melifaro
ae
pauamma_gundo.com
Group Reviewers
network
manpages
Commits
rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius created this revision.Aug 11 2022, 2:29 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 11 2022, 2:29 PM
Herald added subscribers: donner, imp. · View Herald Transcript
glebius requested review of this revision.Aug 11 2022, 2:29 PM
Harbormaster completed remote builds in B46859: Diff 109157.Aug 11 2022, 2:29 PM
pauamma_gundo.com accepted this revision.Aug 12 2022, 7:19 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Manual page change LGTM. Can't say beyond that.

sbin/ipfw/ipfw.8
1101
This revision is now accepted and ready to land.Aug 12 2022, 7:19 PM
ae added a comment.Aug 15 2022, 12:14 PM

Do you plan add similar support for IPv6? There is ICMP6_PACKET_TOO_BIG with the same meaning. But actually it is not unreach message, thus I'm not sure we should do it.

glebius added a comment.Aug 15 2022, 5:54 PM
In D36140#821882, @ae wrote:

Do you plan add similar support for IPv6? There is ICMP6_PACKET_TOO_BIG with the same meaning. But actually it is not unreach message, thus I'm not sure we should do it.

No, I don't plan. Indeed it requires some rethinking of unreach6 action, so that it is able to send not only ICMP6_DST_UNREACH, but other ICMP messages. So for IPv6 the change is possible, but more complicated. I'd better leave it for somebody else :)

ae accepted this revision as: ae.Aug 17 2022, 3:16 PM
Closed by commit rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action (authored by glebius). · Explain WhyAug 17 2022, 3:25 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rG05b9737f1064: ipfw: make it possible to specify MTU for "unreach needfrag" action.

Revision Contents
Changeset List

PathSize
sbin/
ipfw/
10 lines
15 lines
sys/
netpfil/
ipfw/
15 lines
7 lines

Diff 109464

View Options

sbin/ipfw/ipfw.8

Loading...
View Options

sbin/ipfw/ipfw2.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw2.c

Loading...
View Options

sys/netpfil/ipfw/ip_fw_sockopt.c

Loading...