Page MenuHomeFreeBSD
Differential D36135

makefs: Fix issues building as a cross-tool on non-FreeBSD
ClosedPublic
Actions

Authored by jrtc27 on Aug 11 2022, 12:03 AM.
Tags
None
Referenced Files
F115789549: D36135.diff
Mon, Apr 28, 4:59 PM
Unknown Object (File)
Wed, Apr 16, 10:01 PM
Unknown Object (File)
Mar 12 2025, 2:44 AM
Unknown Object (File)
Mar 10 2025, 4:54 AM
Unknown Object (File)
Feb 10 2025, 2:26 PM
Unknown Object (File)
Jan 27 2025, 12:34 AM
Unknown Object (File)
Jan 27 2025, 12:08 AM
Unknown Object (File)
Jan 18 2025, 6:50 AM
View All 63 Files
Subscribers
arichardson
delphij
imp

Details

Reviewers
markj
Commits
rGc6890399fc00: makefs: Fix issues building as a cross-tool on non-FreeBSD
Summary

This adds missing includes, uses the standard dirent.h rather than the
BSD-specific sys/dirent.h subset (which works on macOS but not Linux)
and works around Linux's lack of st_birthtim.

This allows usr.sbin/makefs to be added to LOCAL_XTOOL_DIRS again on
macOS and Linux so that disk images can be cross-built.

Fixes: 240afd8c1fcc ("makefs: Add ZFS support")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46852
Build 43741: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Aug 11 2022, 12:03 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptAug 11 2022, 12:03 AM
jrtc27 requested review of this revision.Aug 11 2022, 12:03 AM
Harbormaster completed remote builds in B46852: Diff 109141.Aug 11 2022, 12:03 AM
jrtc27 added parent revisions: D36134: tools/build: Provide fls* when cross-building on Linux, D36133: tools/build: Provide FreeBSD's bitstring API when cross-building, D36131: makefs: Fix 32-bit issues in ZFS time attributes setting.Aug 11 2022, 12:04 AM
markj accepted this revision.Aug 11 2022, 12:34 AM
This revision is now accepted and ready to land.Aug 11 2022, 12:34 AM
arichardson added a subscriber: arichardson.Aug 11 2022, 10:23 PM

Oh nice, didn't see these changes, I just went for the simple workaround in D36089

arichardson mentioned this in D36089: usr.sbin/makefs: Disable ZFS support when bootstrapping on non-FreeBSD.Aug 11 2022, 10:23 PM
Closed by commit rGc6890399fc00: makefs: Fix issues building as a cross-tool on non-FreeBSD (authored by jrtc27). · Explain WhyAug 18 2022, 1:47 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rGc6890399fc00: makefs: Fix issues building as a cross-tool on non-FreeBSD.

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
zfs/
1 line
8 lines
1 line
1 line
1 line
1 line

Diff 109141

View Options

usr.sbin/makefs/zfs/dsl.c

Loading...
View Options

usr.sbin/makefs/zfs/fs.c

Loading...
View Options

usr.sbin/makefs/zfs/objset.c

Loading...
View Options

usr.sbin/makefs/zfs/vdev.c

Loading...
View Options

usr.sbin/makefs/zfs/zap.c

Loading...
View Options

usr.sbin/makefs/zfs/zfs.h

Loading...