bhyve: Fix -Wunused warnings in pci_nvme.c
ClosedPublic
Actions

Authored by markj on Aug 10 2022, 5:30 PM.

Details

Reviewers

imp
emaste
chuck

Group Reviewers

bhyve

Commits

rGaf86d12c80f1: bhyve: Address -Wunused* warnings in pci_nvme.c

Summary

Currently these are not reported because bhyve is compiled with WARNS=2.
Let's start taking small steps towards enabling more warnings.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 10 2022, 5:30 PM

Herald added a reviewer: bhyve. · View Herald TranscriptAug 10 2022, 5:30 PM

Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Aug 10 2022, 5:30 PM

Harbormaster completed remote builds in B46835: Diff 109109.Aug 10 2022, 5:30 PM

markj added a child revision: D36119: bhyve: Fix uses of uninitialized variables in pci_nvme.c.Aug 10 2022, 5:31 PM

imp accepted this revision.Aug 10 2022, 5:51 PM

This revision is now accepted and ready to land.Aug 10 2022, 5:51 PM

emaste accepted this revision.Aug 10 2022, 6:30 PM

Pass cdw0 through in pci_nvme_set_completion().

This revision now requires review to proceed.Aug 11 2022, 2:46 PM

Harbormaster completed remote builds in B46863: Diff 109167.Aug 11 2022, 2:46 PM

markj mentioned this in D36119: bhyve: Fix uses of uninitialized variables in pci_nvme.c.Aug 11 2022, 2:54 PM

chuck added a reviewer: chuck.Aug 12 2022, 4:02 PM

The 16.0c test pass with these changes.

This revision is now accepted and ready to land.Aug 13 2022, 1:30 AM

Closed by commit rGaf86d12c80f1: bhyve: Address -Wunused* warnings in pci_nvme.c (authored by markj). · Explain WhyAug 14 2022, 4:07 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGaf86d12c80f1: bhyve: Address -Wunused* warnings in pci_nvme.c.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_nvme.c

59 lines

Diff 109330

View Options

bhyve: Fix -Wunused warnings in pci_nvme.cClosedPublicActions