thread_create(): call cpu_copy_thread() after td_pflags is zeroed
ClosedPublic
Actions

Authored by kib on Aug 8 2022, 12:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 18, 2:14 PM

	Unknown Object (File)
	Fri, Oct 18, 2:14 PM

	Unknown Object (File)
	Fri, Oct 18, 2:14 PM

	Unknown Object (File)
	Fri, Oct 18, 2:14 PM

	Unknown Object (File)
	Fri, Oct 18, 1:41 PM

	Unknown Object (File)
	Oct 3 2024, 11:00 PM

	Unknown Object (File)
	Sep 13 2024, 8:34 AM

	Unknown Object (File)
	Sep 9 2024, 2:24 AM

Subscribers

Details

Reviewers

jhb
markj

Commits

rG1b0a4974c500: thread_create(): call cpu_copy_thread() after td_pflags is zeroed

Summary

By calling the function too early we might still have the td_pflags
value cached from the previous struct thread use. cpu_copy_thread()
depends on correct value for TDP_KTHREAD at least on x86.

Reported and tested by:    pho

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 8 2022, 12:10 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 8 2022, 12:10 PM

kib requested review of this revision.Aug 8 2022, 12:10 PM

I think linux_clone_thread() needs the same change?

Handle linuxolator use of cpu_copy_thread() as well

markj accepted this revision.Aug 8 2022, 3:52 PM

This revision is now accepted and ready to land.Aug 8 2022, 3:52 PM

Closed by commit rG1b0a4974c500: thread_create(): call cpu_copy_thread() after td_pflags is zeroed (authored by kib). · Explain WhyAug 8 2022, 4:44 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG1b0a4974c500: thread_create(): call cpu_copy_thread() after td_pflags is zeroed.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_fork.c

4 lines

kern/

kern_thr.c

4 lines

Diff 109010

View Options

sys/compat/linux/linux_fork.c