Page MenuHomeFreeBSD
Differential D35914

stand: Change disk_fmtdev to take a struct devdesc *
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:32 PM.
Tags
None
Referenced Files
F107656646: D35914.id.diff
Fri, Jan 17, 6:34 AM
F107656634: D35914.id109179.diff
Fri, Jan 17, 6:33 AM
F107656624: D35914.id108651.diff
Fri, Jan 17, 6:33 AM
F107656620: D35914.id108510.diff
Fri, Jan 17, 6:33 AM
Unknown Object (File)
Fri, Jan 17, 3:27 AM
Unknown Object (File)
Thu, Jan 9, 10:53 PM
Unknown Object (File)
Nov 16 2024, 11:03 AM
Unknown Object (File)
Nov 16 2024, 10:52 AM
View All 52 Files
Subscribers
dab

Details

Reviewers
tsoome
kevans
manu
Commits
rG9dee581ad980: stand: Change disk_fmtdev to take a struct devdesc *
rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc *
Summary

We do a number of games with ploymorphism for different types struct
*devdesc. Change the parameter to take a struct devdesc * to match other
dv_devfmt functions in the system.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:32 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:32 PM
Herald added a subscriber: dab. · View Herald Transcript
Harbormaster completed remote builds in B46559: Diff 108510.Jul 25 2022, 8:32 PM
imp requested review of this revision.Jul 25 2022, 8:32 PM
imp added a parent revision: D35913: stand: Make sure nobody has a NULL pointer for dv_cleanup.
imp added a child revision: D35915: stand: Add dv_devfmt to return a string represenation of the device.
tsoome added inline comments.Jul 25 2022, 9:49 PM
stand/common/disk.h
118–119

I know it is a bit like documenting, but other prototypes just do show the type.

imp retitled this revision from stand: Change disk_fmtdev to take a void * to stand: Change disk_fmtdev to take a struct devdesc *.Jul 28 2022, 4:54 PM
imp edited the summary of this revision. (Show Details)
imp updated this revision to Diff 108651.Jul 28 2022, 4:57 PM

rework to take devdesc instead to match dv_devfmt

Harbormaster completed remote builds in B46644: Diff 108651.Jul 28 2022, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc * (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGc32dde316692: stand: Change disk_fmtdev to take a struct devdesc *.
imp added a commit: rG9dee581ad980: stand: Change disk_fmtdev to take a struct devdesc *.Jan 24 2023, 10:16 PM

Revision Contents
Changeset List

PathSize
stand/
common/
3 lines
5 lines
libsa/
geli/
2 lines

Diff 109179

View Options

stand/common/disk.h

Loading...
View Options

stand/common/disk.c

Loading...
View Options

stand/libsa/geli/gelidev.c

Loading...